[01:31:01] Project autotest-nightly build #479: STILL FAILING in 22 min. See https://dqtibwqq6s6ux.cloudfront.net for results. [02:00:14] Yippee, build fixed! [02:00:15] Project autotest-nightly build #480: FIXED in 22 min. See https://dqtibwqq6s6ux.cloudfront.net for results. [04:20:45] *** Joins: travis-ci (~travis-ci@ec2-3-87-153-48.compute-1.amazonaws.com) [04:20:46] (spdk/master) rdma: fix potential heap-use-after-free in srq shutdown (Seth Howell) [04:20:46] Diff URL: https://github.com/spdk/spdk/compare/9e1116ea8314...ec47f92b9bc3 [04:20:46] *** Parts: travis-ci (~travis-ci@ec2-3-87-153-48.compute-1.amazonaws.com) () [04:23:40] *** Joins: travis-ci (~travis-ci@ec2-52-90-60-216.compute-1.amazonaws.com) [04:23:41] (spdk/master) test/crypto: move gen_crypto.sh to test directory (Jim Harris) [04:23:41] Diff URL: https://github.com/spdk/spdk/compare/ec47f92b9bc3...196b8e6f275a [04:23:41] *** Parts: travis-ci (~travis-ci@ec2-52-90-60-216.compute-1.amazonaws.com) () [08:47:14] *** Joins: emce (~emce@15.203.226.47) [08:52:18] *** Quits: emce (~emce@15.203.226.47) (Ping timeout: 258 seconds) [08:53:20] *** Joins: emce (~emce@15.203.226.48) [09:08:48] *** Quits: tomzawadzki (uid327004@gateway/web/irccloud.com/x-wlijpopehsshiskg) (Quit: Connection closed for inactivity) [09:40:14] sethhowe: i'm looking at the rocksdb repo - what branch has this e32952ef commit (the one in the rocksdb_commit_id file) [09:45:26] jimharris: I was under the impression that it was the tip of 5.6.1, but upon closer inspection, that is not the case. [09:45:50] yeah - i can't find this commit id anywhere in my repo [09:48:04] jimharris: I think it's working by accident right now because we check out the tip of that branch upon clone, then when checking out the bad commit, it just silently fails. [09:48:49] ok - so it think it should be 803b318 then? [09:49:13] yes. https://review.gerrithub.io/c/spdk/spdk/+/452245 [09:49:47] That's my bad. Not sure how I managed to screw that up. [09:49:57] no worries [09:50:17] i need to coordinate a rocksdb change with an spdk change so i'm going to put this new functionality to good use :) [10:03:16] jimharris: patches are ready for review, starting with this one: https://review.gerrithub.io/c/spdk/spdk/+/452240/2 [10:53:49] Just put up a PR to gerrit, do I need to add reviewers at all? [10:59:38] nope we just find it [11:00:02] awesome, thanks a bunch [11:04:53] hi emce - just posted a few comments - overall looks good though [11:05:18] i assigned it to klateck as well since he's done most of the spdkcli development to this point [11:05:39] sounds good jimharris, thanks for the review [11:06:56] you may also want to consider adding some tests for this new functionality in the test/spdkcli directory [11:07:12] you can just add something to one of the existing tests - iscsi.sh for example [11:07:34] will do! [11:08:50] i'm no expert on modifying the test/spdkcli/match_files though - but if you have any questions or issues, klateck will be more than happy to help answer them [11:15:29] *** Joins: travis-ci (~travis-ci@ec2-52-91-36-167.compute-1.amazonaws.com) [11:15:30] (spdk/master) rdma: don't spam people with async event messages. (Seth Howell) [11:15:30] Diff URL: https://github.com/spdk/spdk/compare/196b8e6f275a...d05c55382767 [11:15:30] *** Parts: travis-ci (~travis-ci@ec2-52-91-36-167.compute-1.amazonaws.com) () [11:54:30] is it possible to just run one of the tests, i.e. ./test/spdkcli/iscsi.sh ? Or is there more to this I'm missing? [12:37:10] some of the tests are set up to run in isolation [12:37:12] but not all just yet [12:37:21] I don't know about that one specifically [12:44:59] jimharris, bwalker my patches are ready for review now :) [12:46:42] taking it back... I need to fix one white space [12:50:39] ok, now it's ready [12:51:31] by mistake I changed variable name in _spdk_bs_is_blob_deletable function, between patches... I think the name now i better, but if you want i can change the name in original patch, not in between them ;) [12:54:27] change it in the original patch please :) [13:12:08] *** Joins: travis-ci (~travis-ci@ec2-54-156-155-43.compute-1.amazonaws.com) [13:12:09] (spdk/master) rocksdb: point the commit to the head of spdk-5.6.1 (Seth Howell) [13:12:09] Diff URL: https://github.com/spdk/spdk/compare/d05c55382767...0242029aec8b [13:12:09] *** Parts: travis-ci (~travis-ci@ec2-54-156-155-43.compute-1.amazonaws.com) () [13:22:43] jimharris: done :) [13:33:26] i posted a few more comments - one is a critical bug i missed until just now [13:49:43] just posted a few more comments [14:08:36] done, done and done :) [15:02:37] emce: you still there? [15:02:46] Yep! [15:02:56] saw your latest comment on Gerrithub [15:03:13] i was wondering how you came up with "Pooled" and now I know why [15:03:51] a bit of history - when this was originally written, the author named the module "pooled" and we had him change it to "raid" - he did the global search and replace, but this one got missed [15:04:26] Ah good to know, I wasn't sure what to make of it [15:04:58] my first reaction is to change the product_name [15:05:17] to "Raid Volume" -especially if we add things like mirroring in the future [15:06:14] ok and that would lead to the spdk cli displaying 'raid_volume' as the bdev type, that good with you? [15:06:31] This all sounds very reasonable to me [15:06:32] yes - I think that's preferred [15:07:09] my only concern is anyone else depending on these RAID volume returning "Pooled Device" as the product name - but I think we can document that change [15:07:29] could you do one patch first that just changes the product name, and then your spdk cli patch? [15:08:03] Yeah will do, give me a little bit [15:08:28] Should I document the change? if so, where do I do that? [15:08:31] np [15:08:51] good question :) you can do it in the CHANGELOG file in the root of the repo [15:10:00] right on, I'll have that change up in just a little bit [15:10:51] i'm not sure we'll get this in for the 19.04 release next week - but we can definitely get it merged to master right afterwards, and cherry picked to the upcoming 19.04.x stable branch [15:13:00] Sounds good to me. I'm not in a rush for these changes. Was attempting to get them in with the release following 19.04 [15:19:42] Should I put this change under the ## v19.04 section? or should I make a new one entirely (## v19.04.1:)? [15:24:37] *** Quits: gila (~gila@94-212-217-121.cable.dynamic.v4.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [15:32:11] jimharris: patch is ready for review -- https://review.gerrithub.io/c/spdk/spdk/+/452269 [15:35:37] just saw it - +2 [15:35:53] thanks for finding all of the other usages of "pooled" and cleaning those up too [15:36:04] np! [15:38:53] Once this one's merged in, I'll update my other patch for spdkcli raid support. I've got the unit testing all ready and I'll update it to support the new naming convention as well. [15:39:11] Thanks again for all the help today! [15:39:47] ok - you should be able to push your spdkcli patch based on top of the product name patch [15:39:59] if you're interested - or you can just wait until the first one is merged [15:40:12] Oh didn't realize I could. Let me look into doing that :) [16:13:23] *** Joins: travis-ci (~travis-ci@ec2-52-90-60-216.compute-1.amazonaws.com) [16:13:24] (spdk/master) blobstore: Add _spdk_bs_delete_blob_finish function (Maciej Szwed) [16:13:24] Diff URL: https://github.com/spdk/spdk/compare/0242029aec8b...ee430f97b022 [16:13:24] *** Parts: travis-ci (~travis-ci@ec2-52-90-60-216.compute-1.amazonaws.com) ()