[01:34:44] *** Joins: travis-ci (~travis-ci@ec2-54-196-31-156.compute-1.amazonaws.com) [01:34:45] (spdk/v19.01.x) SPDK 19.01 (Tomasz Zawadzki) [01:34:45] Diff URL: https://github.com/spdk/spdk/compare/v19.01.x [01:34:45] *** Parts: travis-ci (~travis-ci@ec2-54-196-31-156.compute-1.amazonaws.com) () [01:36:56] *** Joins: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) [01:46:42] *** Quits: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) (Remote host closed the connection) [01:47:08] *** Joins: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) [08:20:42] *** Joins: travis-ci (~travis-ci@ec2-54-160-226-173.compute-1.amazonaws.com) [08:20:43] (spdk/master) bdev/aio: Remove list of channels on channel group (Ben Walker) [08:20:43] Diff URL: https://github.com/spdk/spdk/compare/8629d8da6644...4ea3e63291cb [08:20:43] *** Parts: travis-ci (~travis-ci@ec2-54-160-226-173.compute-1.amazonaws.com) () [08:44:47] darsto: thanks for getting the dpdk submodule patches ready! are there any spdk changes needed to build/run with dpdk 19.02 that you are aware of yet? [08:46:57] jimharris: i'm still working on getting crypto ready [08:47:04] then i'll run the full test suite on jenkins [08:47:40] ok [08:48:08] i've +2'd the patches - you can go ahead and manually add the +1 verified after you run the full test suite [09:07:58] *** Joins: travis-ci (~travis-ci@ec2-52-55-141-30.compute-1.amazonaws.com) [09:07:59] (spdk/master) nvme: Update p2p DMA documentation to indicate how to check for support (Ben Walker) [09:08:00] Diff URL: https://github.com/spdk/spdk/compare/4ea3e63291cb...1de99be6cfe5 [09:08:00] *** Parts: travis-ci (~travis-ci@ec2-52-55-141-30.compute-1.amazonaws.com) () [09:08:49] *** Joins: travis-ci (~travis-ci@ec2-54-160-226-173.compute-1.amazonaws.com) [09:08:50] (spdk/master) nvmf/tcp: Eliminate management channel in favor of poll group (Ben Walker) [09:08:50] Diff URL: https://github.com/spdk/spdk/compare/1de99be6cfe5...63de221bf630 [09:08:50] *** Parts: travis-ci (~travis-ci@ec2-54-160-226-173.compute-1.amazonaws.com) () [09:47:18] when you push something to gerrithub, do i need to do something else for you guys to see it? i.e assign it to someone? or ... [09:47:55] no - we poll gerrithub for new reviews with queries [09:48:01] no need to generate an interrupt [10:15:34] hehe, the spdk way :) [10:39:28] *** Joins: travis-ci (~travis-ci@ec2-54-204-209-146.compute-1.amazonaws.com) [10:39:29] (spdk/master) test/nvmf: add connect disconnect test (Seth Howell) [10:39:29] Diff URL: https://github.com/spdk/spdk/compare/63de221bf630...5c97ac16362d [10:39:29] *** Parts: travis-ci (~travis-ci@ec2-54-204-209-146.compute-1.amazonaws.com) () [10:56:38] *** Joins: travis-ci (~travis-ci@ec2-54-227-123-82.compute-1.amazonaws.com) [10:56:39] (spdk/master) test/common: spdk_mempool mock configurable element size (Wojciech Malikowski) [10:56:39] Diff URL: https://github.com/spdk/spdk/compare/5c97ac16362d...a4968634f132 [10:56:39] *** Parts: travis-ci (~travis-ci@ec2-54-227-123-82.compute-1.amazonaws.com) () [11:45:42] *** Joins: travis-ci (~travis-ci@ec2-54-204-209-146.compute-1.amazonaws.com) [11:45:43] (spdk/master) nvme/pcie: mark infrequent cases as unlikely in submission path (lorneli) [11:45:43] Diff URL: https://github.com/spdk/spdk/compare/a4968634f132...4b6621d08ec3 [11:45:43] *** Parts: travis-ci (~travis-ci@ec2-54-204-209-146.compute-1.amazonaws.com) () [12:09:47] *** Joins: travis-ci (~travis-ci@ec2-54-236-107-116.compute-1.amazonaws.com) [12:09:48] (spdk/master) vhost/rpc: remove unnecessary if in the add_vhost_scsi_lun RPC (Darek Stojaczyk) [12:09:49] Diff URL: https://github.com/spdk/spdk/compare/4b6621d08ec3...1dc9e7024b9d [12:09:49] *** Parts: travis-ci (~travis-ci@ec2-54-236-107-116.compute-1.amazonaws.com) () [12:14:28] gila: posted a comment on your macro patch [12:14:49] Thanks for the interrupt (trying to amuse [12:14:53] @peluse [12:21:41] @jimharris for some reason I cant reply to your comment, so here goes. Im fine with doing what you suggest. In fact i asked what the preferred approach was on the mailing list. Ben said he liked it so I want ahead so im fine either way. Your suggestion is more in line with the SPDK_NET_XXX_REGISTER() approach though. [12:26:53] gerrithub is throwing err 500 again [12:27:10] my guess is bwalker just hadn't looked at the details on this before responding (i.e. how each module names it's module structure differently) [12:27:14] yeah - me too [12:27:23] i was trying to remove a +2 from bwalker on https://review.gerrithub.io/#/c/spdk/spdk/+/442776/ :) [12:27:56] sethhowe: can you look at my comment on this 442776 patch and see if it makes sense? [12:30:16] I almost commented on that one that we should rename DEFAULT to MIN, not realizing there was already an (unused) MIN [12:37:40] @jimharris Ok no problem, i'll make the suggested changes and update the review. [12:38:45] argh - gerrithub is throwing 500 whenever i try to type in an assignee [12:40:21] i can't even push anything through git [12:40:50] i'm sending an e-mail to support - will copy you [12:42:20] Yeah, it won't even open for me right now. [12:44:47] working fine for me [12:45:11] can you try to do something like assign an nvme rdma patch to yourself? [12:46:00] 500 error [12:46:17] but reviewing and writing comments works [12:47:13] i sent an e-mail to gerritforge support - can't merge patches either [13:27:57] *** Joins: travis-ci (~travis-ci@ec2-54-227-123-82.compute-1.amazonaws.com) [13:27:58] (spdk/master) env/dpdk: remove rte_pci_bus extern declaration (Darek Stojaczyk) [13:27:59] Diff URL: https://github.com/spdk/spdk/compare/95200f5bacb4...f22de50beec8 [13:27:59] *** Parts: travis-ci (~travis-ci@ec2-54-227-123-82.compute-1.amazonaws.com) () [13:28:31] *** Joins: travis-ci (~travis-ci@ec2-54-221-129-99.compute-1.amazonaws.com) [13:28:32] (spdk/master) iscsi: remove unused mobj fields (Darek Stojaczyk) [13:28:32] Diff URL: https://github.com/spdk/spdk/compare/1dc9e7024b9d...95200f5bacb4 [13:28:32] *** Parts: travis-ci (~travis-ci@ec2-54-221-129-99.compute-1.amazonaws.com) () [13:37:08] gerritforge reports everything should be back to normal, although they're still investigating exactly what happened [13:37:14] things look better on my end [15:40:03] *** Quits: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) (Ping timeout: 245 seconds) [15:41:09] *** Joins: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) [15:49:58] *** Quits: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) (Ping timeout: 246 seconds) [15:52:26] *** Joins: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) [16:37:22] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [16:40:11] *** Quits: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [16:42:18] @jimharris, @bwalker: Thank you for reviews. I will spend today to sudden office work, and will restart tomorrow. [16:58:21] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 256 seconds) [18:29:20] *** Quits: bwalker (bwalker@nat/intel/x-ayemmwoqlnntkfnf) (ZNC - http://znc.in)