[00:23:11] *** Quits: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) (Read error: Connection reset by peer) [00:26:23] *** Joins: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) [00:58:34] *** Joins: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) [01:00:37] *** Quits: ziyeyang__ (ziyeyang@nat/intel/x-inpleevtimuetpuf) (Quit: Leaving) [01:07:24] *** Joins: travis-ci (~travis-ci@ec2-54-211-253-58.compute-1.amazonaws.com) [01:07:25] (spdk/master) bdev/aio: unregister io_device correctly (Jim Harris) [01:07:25] Diff URL: https://github.com/spdk/spdk/compare/a3777e3f1143...d3bfd244f09b [01:07:25] *** Parts: travis-ci (~travis-ci@ec2-54-211-253-58.compute-1.amazonaws.com) () [01:35:44] *** Joins: travis-ci (~travis-ci@ec2-54-83-78-36.compute-1.amazonaws.com) [01:35:45] (spdk/master) spdk: Add ISA-L support with related crc32 function (Ziye Yang) [01:35:45] Diff URL: https://github.com/spdk/spdk/compare/d3bfd244f09b...552e21cce6cc [01:35:45] *** Parts: travis-ci (~travis-ci@ec2-54-83-78-36.compute-1.amazonaws.com) () [01:51:19] *** Joins: travis-ci (~travis-ci@ec2-54-211-253-58.compute-1.amazonaws.com) [01:51:20] (spdk/master) test/crypto_ut: change alignment of allocation (Seth Howell) [01:51:20] Diff URL: https://github.com/spdk/spdk/compare/552e21cce6cc...9042f3468b5a [01:51:20] *** Parts: travis-ci (~travis-ci@ec2-54-211-253-58.compute-1.amazonaws.com) () [05:28:14] peluse: thanks, nvme-cli fix here https://review.gerrithub.io/c/spdk/spdk/+/442552 [05:31:22] nvmf.c:774:2: runtime error: member access within null pointer of type 'struct spdk_nvmf_poll_group' [05:31:22] #0 0x5cb9ce in spdk_nvmf_qpair_disconnect /var/jenkins/workspace/NVMeOF_tests/nvmf_phy_autotest/spdk/lib/nvmf/nvmf.c:774 [05:31:44] does it look familiar to anyone? [06:04:52] *** Quits: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) (Ping timeout: 244 seconds) [06:19:02] *** Joins: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) [07:05:17] *** Joins: travis-ci (~travis-ci@ec2-54-204-204-242.compute-1.amazonaws.com) [07:05:18] (spdk/master) test/common: suppress waitforlisten output on BSD (Darek Stojaczyk) [07:05:18] Diff URL: https://github.com/spdk/spdk/compare/9042f3468b5a...6903c407a5e9 [07:05:18] *** Parts: travis-ci (~travis-ci@ec2-54-204-204-242.compute-1.amazonaws.com) () [07:44:58] I should get used to announcing bug scrub meetings [07:45:57] Bug scrub meeting starts in 15 mins - https://www.freeconferencecall.com/wall/paul_e_luse [08:01:09] *** Joins: vmysak (~vmysak@192.55.54.45) [08:02:06] *** Joins: travis-ci (~travis-ci@ec2-54-162-16-201.compute-1.amazonaws.com) [08:02:07] (spdk/master) util/string: additional errno check after strtol() (Wojciech Malikowski) [08:02:07] Diff URL: https://github.com/spdk/spdk/compare/6903c407a5e9...f0e6bbea0a06 [08:02:07] *** Parts: travis-ci (~travis-ci@ec2-54-162-16-201.compute-1.amazonaws.com) () [08:24:54] *** Quits: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) (Remote host closed the connection) [08:52:56] *** Quits: vmysak (~vmysak@192.55.54.45) (Ping timeout: 240 seconds) [08:53:06] bwalker or darsto: can one of you look at https://review.gerrithub.io/c/spdk/spdk/+/442522 [09:21:19] jimharris: Do we need to mark the configuration file parsing as deprecated this release? [09:21:26] with like a warning if you use it [09:21:42] that's probably a good idea [09:21:52] ok, I'll put in a patch that points people at the config converter [09:22:23] i doubt we'll remove it in 19.04? but at least then we have precedence for only adding new configuration features to JSON [09:22:39] yeah we'll probably leave it in for a long time but I want to draw a line in the sand [09:34:42] jimharris: you merged this one https://review.gerrithub.io/c/spdk/spdk/+/441626/9 but not the large series of patches on top of it that use the new function (one or two were missing +2s). Do you think we should go ahead with those? The new function is listed in CHANGELOG.md, but not used yet. [10:24:11] i merged everything up to one that darsto had -1'd [10:24:50] i'm fine with merging more of them [10:25:22] I think shuhei fixed the issue that darsto pointed out [10:25:35] but a few of the patches haven't been re-reviewed yet [10:25:52] this one had the iscsi calsoft intermittent failure that i pushed the fix out for yesterday: https://review.gerrithub.io/c/spdk/spdk/+/442493 [10:26:02] i think we should consider merging that [10:26:20] I think so - I hit that calsoft issue twice yesterday [10:27:08] reviewing now [10:27:27] let me take a second look at those patches [10:27:58] cool - i'll let darsto check out those patches - go ahead and merge them when you're done darsto [10:28:41] here's the calsoft fix: https://review.gerrithub.io/c/spdk/spdk/+/442449/2 [10:33:07] I think that whole series through here: https://review.gerrithub.io/c/spdk/spdk/+/442494 looks good [10:33:26] just solid improvements to input parsing, mostly low risk [10:39:35] merged all of them [10:39:56] do we need this in 19.01? https://review.gerrithub.io/c/spdk/spdk/+/442523 [10:40:43] i'd say yes [10:41:30] teag [10:41:32] yeah [10:41:38] change 'folder' to 'directory' [10:41:49] I know you didn't write that [10:41:55] but we're here [10:42:10] actually, it's fine [10:42:14] can do a different patch for that [10:43:02] *** Joins: travis-ci (~travis-ci@ec2-54-211-253-58.compute-1.amazonaws.com) [10:43:03] (spdk/master) bdev_ftl: Added FTL bdev functional tests (Wojciech Malikowski) [10:43:04] Diff URL: https://github.com/spdk/spdk/compare/45d0c054121f...ca558b616356 [10:43:04] *** Parts: travis-ci (~travis-ci@ec2-54-211-253-58.compute-1.amazonaws.com) () [10:44:33] delete_bdev RPC [10:45:41] *** Joins: travis-ci (~travis-ci@ec2-54-167-54-101.compute-1.amazonaws.com) [10:45:42] (spdk/master) bdev/null: Remove clearing errno duplicated with spdk_strtol (Shuhei Matsumoto) [10:45:42] Diff URL: https://github.com/spdk/spdk/compare/ca558b616356...67c3074b908b [10:45:42] *** Parts: travis-ci (~travis-ci@ec2-54-167-54-101.compute-1.amazonaws.com) () [10:46:16] what about delete_bdev? [10:46:19] mark deprecated? [10:46:20] that's another RPC that we deprecated a while back - we don't use it anywhere in SPDK anymore [10:46:53] I don't see an official deprecation warning - although a changelog entry says it is to be used for debugging only [10:47:06] https://review.gerrithub.io/c/spdk/spdk/+/442615 [10:47:38] hmmmm - well, I think we should mark it deprecated then and remove it in 19.04 [10:48:18] it just doesn't work in a lot of cases - if you want to simulate hotplug, just delete the malloc bdev, or the nvme controller that contains your namespace [10:49:56] so you want to keep it for 19.01 but mark it deprecated? i can add a doc patch to do that [10:50:10] *** Joins: travis-ci (~travis-ci@ec2-54-162-16-201.compute-1.amazonaws.com) [10:50:11] (spdk/master) configure: fix building without isa-l submodule (Darek Stojaczyk) [10:50:12] Diff URL: https://github.com/spdk/spdk/compare/891bf99aaa42...385f42eb97b4 [10:50:12] *** Parts: travis-ci (~travis-ci@ec2-54-162-16-201.compute-1.amazonaws.com) () [10:50:13] I doubt anyone is using it because it doesn't really work [10:50:24] so I'd be ok with removing it [10:50:34] but officially we should mark it deprecated for one release [10:53:09] hmm I'm not sure we've worked through the details of running the fio plugin without a configuration file [10:53:33] or bdevperf [10:54:46] we'll need JSON-RPC versions of things like scripts/gen_nvme.sh [10:55:00] yeah - I don't think we can deprecate it for 19.01 [10:55:03] have to wait for 19.04 [10:55:13] ha - what am I saying - scripts/gen_nvme.sh already supports JSON-RPC format [10:55:35] I think it might just be the fio plugin and bdevperf startup sequence [10:55:38] that needs to be looked at [10:56:05] we also want to get rid of discover_bdevs [10:56:26] and probably bdev_svc application [10:57:52] what do you replace that with? [10:58:38] I think you have to load something up to get the right information to generate the fio configuration file [10:58:39] for discover_bdevs you can just name your bdevs within the script [10:59:19] not a problem if all bdevs are added through rpc rather than config files [10:59:40] yeah ok - in that case you've explicitly named them all [10:59:42] as you created them [10:59:56] what about lvols? [11:00:48] ok - that could be a problem [11:02:10] what about this one? https://review.gerrithub.io/c/spdk/spdk/+/440828 [11:04:02] i'm ok merging it [11:10:04] darsto: I rebased https://review.gerrithub.io/c/spdk/spdk/+/433385 - merge conflict with the strtoll changes [11:11:31] +2 [11:13:06] we also need to mention this tool in changelog [11:16:05] https://review.gerrithub.io/c/spdk/spdk/+/442552 "test/nvmf/nvme-cli: don't run nvme-cli as secondary process" [11:16:13] and what about that one? [11:25:00] can you make sure to tell Tomek to update changelong patch to include that tool? [11:28:09] *** Joins: travis-ci (~travis-ci@ec2-54-162-223-59.compute-1.amazonaws.com) [11:28:10] (spdk/master) Update spdk crc32.c with ARM CRC32 intrinsics (Richael Zhuang) [11:28:10] Diff URL: https://github.com/spdk/spdk/compare/7d1db86f54b3...a23b8c8c0aa0 [11:28:10] *** Parts: travis-ci (~travis-ci@ec2-54-162-223-59.compute-1.amazonaws.com) () [11:30:06] can someone pls remove the CH TP -1 from this patch? Thanks1 https://review.gerrithub.io/c/spdk/spdk/+/442325 [12:18:50] lhodev, hey I can't find your email for some reason - need to ask a favor if you could shoot it over to me. thanks! [12:24:26] lhodev, never mind, I got it.... [13:25:18] sethhowe, bwalker: here are some links to that intermittent failure i mentioned earlier [13:25:19] http://10.102.17.206/results/autotest-per-patch/builds/21479/archive/nvmf_phy_autotest/build.log [13:25:37] right after we talked in the lab, one of my patches hit it [13:26:45] http://10.102.17.206/results/autotest-per-patch/builds/21465/archive/nvmf_phy_autotest/build.log [13:31:26] *** Joins: travis-ci (~travis-ci@ec2-54-166-120-10.compute-1.amazonaws.com) [13:31:27] (spdk/master) test/vhost: vhost benchmark scripts update (Karol Latecki) [13:31:28] Diff URL: https://github.com/spdk/spdk/compare/a23b8c8c0aa0...80a9ef40425a [13:31:28] *** Parts: travis-ci (~travis-ci@ec2-54-166-120-10.compute-1.amazonaws.com) () [13:34:25] *** Joins: travis-ci (~travis-ci@ec2-54-161-144-212.compute-1.amazonaws.com) [13:34:26] (spdk/master) doc/lvol: add description for clear-method when creating lvol bdevs (Tomasz Zawadzki) [13:34:26] Diff URL: https://github.com/spdk/spdk/compare/80a9ef40425a...0c0d9d4e0a97 [13:34:26] *** Parts: travis-ci (~travis-ci@ec2-54-161-144-212.compute-1.amazonaws.com) () [13:54:32] jimharris: please see https://review.gerrithub.io/c/spdk/spdk/+/442629 [13:57:14] darsto: Made a comment [14:04:44] should we just close this one if we're going to shut down the CTP? https://github.com/spdk/spdk/issues/601 [14:06:15] yeah [15:07:01] https://ci.spdk.io/spdk-jenkins/results/autotest-per-patch/builds/21492/archive/nvmf_phy_autotest/build.log [16:11:21] *** Joins: gila (~gila@185.107.94.175) [16:42:00] *** Quits: gila (~gila@185.107.94.175) (Ping timeout: 250 seconds) [17:53:09] *** Joins: travis-ci (~travis-ci@ec2-54-162-16-201.compute-1.amazonaws.com) [17:53:10] (spdk/master) bdev: mark delete_bdev RPC deprecated (Jim Harris) [17:53:10] Diff URL: https://github.com/spdk/spdk/compare/20f4a21d8405...abc156458fff [17:53:10] *** Parts: travis-ci (~travis-ci@ec2-54-162-16-201.compute-1.amazonaws.com) () [17:56:12] *** Joins: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) [18:01:29] *** Quits: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [23:41:24] *** Joins: travis-ci (~travis-ci@ec2-54-162-223-59.compute-1.amazonaws.com) [23:41:25] (spdk/master) lib/trace: add trace_record tool (Liu Xiaodong) [23:41:25] Diff URL: https://github.com/spdk/spdk/compare/abc156458fff...a206234d09f8 [23:41:25] *** Parts: travis-ci (~travis-ci@ec2-54-162-223-59.compute-1.amazonaws.com) () [23:42:14] *** Joins: travis-ci (~travis-ci@ec2-54-205-70-93.compute-1.amazonaws.com) [23:42:15] (spdk/master) bdevperf: remove extra blockdev_heads_destroy() in failure path (Jim Harris) [23:42:15] Diff URL: https://github.com/spdk/spdk/compare/a206234d09f8...ab696ae1cfb9 [23:42:15] *** Parts: travis-ci (~travis-ci@ec2-54-205-70-93.compute-1.amazonaws.com) ()