[00:58:45] *** Joins: gila (~gila@5ED74129.cm-7-8b.dynamic.ziggo.nl) [01:29:22] *** Joins: tomzawadzki (uid327004@gateway/web/irccloud.com/x-gskqfbsnhjqrdbgo) [04:14:22] *** Joins: alekseymmm (050811aa@gateway/web/freenode/ip.5.8.17.170) [07:37:38] ITP CI folks: Something I haven't seen before, please look at this "patch unrelated" failure, well from what I can tell.... https://ci.spdk.io/spdk-jenkins/results/autotest-per-patch/builds/14420/archive/blockdev_autotest/build.log [07:51:10] @peluse It looks like one of the Jenkins node have troubles with fetching repo [07:51:40] I've retriggered failed builds [07:53:39] thanks! [08:33:59] *** Joins: travis-ci (~travis-ci@ec2-54-226-93-95.compute-1.amazonaws.com) [08:34:00] (spdk/master) fio_plugin: Move spdk_fio_module_finish_done up (Ben Walker) [08:34:00] Diff URL: https://github.com/spdk/spdk/compare/f06d3d3bbf57...48c852498381 [08:34:00] *** Parts: travis-ci (~travis-ci@ec2-54-226-93-95.compute-1.amazonaws.com) () [08:56:23] *** Quits: drv (daniel@oak.drv.nu) (Remote host closed the connection) [08:58:43] *** Joins: drv (daniel@oak.drv.nu) [08:58:44] *** ChanServ sets mode: +o drv [10:29:04] *** Quits: tomzawadzki (uid327004@gateway/web/irccloud.com/x-gskqfbsnhjqrdbgo) (Quit: Connection closed for inactivity) [10:35:52] *** Joins: travis-ci (~travis-ci@ec2-54-234-151-219.compute-1.amazonaws.com) [10:35:53] (spdk/master) passthru: add RPC testing (paul luse) [10:35:53] Diff URL: https://github.com/spdk/spdk/compare/48c852498381...164d79143be2 [10:35:53] *** Parts: travis-ci (~travis-ci@ec2-54-234-151-219.compute-1.amazonaws.com) () [10:37:37] *** Joins: LiuXiaodong (86868b48@gateway/web/freenode/ip.134.134.139.72) [11:03:44] *** Quits: LiuXiaodong (86868b48@gateway/web/freenode/ip.134.134.139.72) (Quit: Page closed) [11:04:34] *** Joins: LiuXiaodong (86868b48@gateway/web/freenode/ip.134.134.139.72) [11:34:26] *** Quits: bwalker (~bwalker@134.134.139.72) (ZNC - http://znc.in) [11:39:12] *** Joins: bwalker (bwalker@nat/intel/x-hafswerldklqlmzb) [11:39:12] *** ChanServ sets mode: +o bwalker [11:39:12] *** Server sets mode: +cnrt [11:39:12] *** Server sets mode: +cnrt [11:44:07] *** Joins: jimharris (jimharris@nat/intel/x-hkrhwdlkmzuvfwgu) [11:44:07] *** ChanServ sets mode: +o jimharris [11:59:38] *** Joins: ppelplin (~ppelplin@134.134.139.72) [12:07:18] *** Joins: travis-ci (~travis-ci@ec2-54-147-199-7.compute-1.amazonaws.com) [12:07:19] (spdk/master) jsonrpc: introduce spdk_jsonrpc_client_response (Pawel Wodkowski) [12:07:19] Diff URL: https://github.com/spdk/spdk/compare/b8dc21cb7841...5d0f26207324 [12:07:19] *** Parts: travis-ci (~travis-ci@ec2-54-147-199-7.compute-1.amazonaws.com) () [14:15:06] *** Joins: peluse (peluse@nat/intel/x-wiibhapkstphwgzp) [14:15:07] *** ChanServ sets mode: +o peluse [14:29:27] FYI I root caused the 'crypto issue' I mentioned last night or whenever that was... on the dev machine that I did the original dev work on there was an old style (and old version) of the ipsec lib floating around. The error I was getting was from ipsec lib and didn't show up until the new DPDK. Once I manually cleaned off all the old ipseclib stuff, things worked fine [14:30:37] Hey jimharris. Any thoughts about Pawel's response about the version # in the spec file? https://review.gerrithub.io/#/c/spdk/spdk/+/424973/ [14:34:39] i don't agree [14:35:03] i really don't think we want the spec file's version on master to appear like it's a tagged release [14:35:32] i think master gets 19.01-pre, and then part of the release process is updating the spec file (just like we do with include/spdk/version.h) [14:37:28] I'm fine with that. As I commented in the change, my only insistence was that it was *not* just "18.10". [14:40:06] From my view of how OL manages the lion's share of user packages, the spec file has the version # aligned with the version of the source in a specific branch for that version. [14:48:26] *** Joins: pawelkax (pawelkax@nat/intel/x-rhgrbzudlbbotbug) [15:43:49] *** Quits: gila (~gila@5ED74129.cm-7-8b.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [15:46:02] *** Joins: sethhowe (~sethhowe@134.134.139.72) [16:17:41] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [16:18:28] jimharris: I've started to review the patch series for libreduce. I'll let you know if it completes. [16:19:23] thanks Shuhei! [16:30:11] jimharris: Please update the header file too for https://review.gerrithub.io/#/c/spdk/spdk/+/430387/. [16:30:20] -1 to negative/negate. [16:32:50] good catch Shuhei - I've updated the patch now (to say -EINVAL instead of -1) [16:41:36] Jim, It looks that Pawel's feedback is not addressed in https://review.gerrithub.io/#/c/spdk/spdk/+/430645/. [16:41:48] size_needed < 0 || size_needed > size ? [17:00:10] the validate_vol_params check just above ensures that doesn't happen [17:06:59] *** Quits: LiuXiaodong (86868b48@gateway/web/freenode/ip.134.134.139.72) (Ping timeout: 256 seconds) [17:08:52] _validate_vol_params is duplicated in spdk_reduce_get_pm_file_size and spdk_reduce_vol_init. But both are public API. [20:04:21] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 256 seconds) [21:14:42] *** Joins: tomzawadzki (uid327004@gateway/web/irccloud.com/x-hhzfxgmnwsajjxly) [23:21:13] *** Joins: pwodkowx (~pwodkowx@134.134.139.72) [23:53:04] *** Quits: stefanha (~stefanha@yuzuki.vmsplice.net) (Ping timeout: 246 seconds)