[00:54:22] *** Joins: alekseymmm (050811aa@gateway/web/freenode/ip.5.8.17.170) [01:43:39] peluse: I'm now :) [06:56:15] pwodkowx, haha OK. Was going to ask about some of the json APIs used in the dump and config functions, I put a comment in the crypto cleanup patch [06:59:12] pwodkowx, this question: I'm reverting the last suggested change to vbdev_crypto_dump_info_json() as it would require me to put a parm of some kind in the write message. Looking at all other bdev modules dump routines, none of them are using the write_named_object as was suggested in the review. It's not really clear to me when/why/what the difference is in some of the json write routines, will get some more education on that later but for now this is how [06:59:12] all the others are written. If this is a real error please let me know [07:00:10] yes, they are, because there were no name API there. named suggest that you are writin key, value pair (at least to me) [07:00:40] no named API suggest just element like in array so it is easier to review the code [07:00:53] also ~50% less lines to write :) [07:04:28] so where you suggested to use named API was vbdev_crypto_dump_info_json where I'm just writing the name of the crypto device followed by a bunch of paired values. Why did you suggest using the named API for just writing the single value? [07:05:32] actually the LOC in question is just writing like a title value I guess, just "crypto" [07:05:45] (not the name of the crypto device like I said above) [08:37:45] uhh, my patch is a hive of intermittent failures. 421158: bdev: do not finish unitialized modules [11:38:55] *** Joins: travis-ci (~travis-ci@ec2-54-226-194-105.compute-1.amazonaws.com) [11:38:56] (spdk/master) test: No longer use construct_nvmf_subsystem (Ben Walker) [11:38:56] Diff URL: https://github.com/spdk/spdk/compare/33ed49d2e999...ec1f425841f6 [11:38:56] *** Parts: travis-ci (~travis-ci@ec2-54-226-194-105.compute-1.amazonaws.com) () [11:47:29] jimharris, wrt your comment on the initial crypto patch and no rpc test coverage, please see https://review.gerrithub.io/#/c/spdk/spdk/+/425875 and let me know what you think. Found some issues testing it in CI as opposed to simple cmd line stuff I was doing.... not urgent by any stretch [11:50:54] overall looks great - one suggestion i just posted to reduce the size of the patch [11:51:12] but functionally it's fine and the rpc coverage added is perfect [13:12:56] jimharris, cool, thanks! [13:13:36] That whole test, json_config, is what I was proposing we add - didn't know it was already there LOL [13:57:08] jimharris, FYI just ran fio w/host kernel initiator and our target with target setup w/crypto on an nvme drive! [13:57:16] with some help from sethhowe and bwalker of course :) [14:55:16] *** Joins: travis-ci (~travis-ci@ec2-54-158-167-15.compute-1.amazonaws.com) [14:55:17] (spdk/master) env: Fix spdk_ring creation and access. (John Barnard) [14:55:17] Diff URL: https://github.com/spdk/spdk/compare/ec1f425841f6...9c8435b64968 [14:55:17] *** Parts: travis-ci (~travis-ci@ec2-54-158-167-15.compute-1.amazonaws.com) () [14:55:43] *** Joins: travis-ci (~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com) [14:55:44] (spdk/master) test/iscsi: disable running_config test (Karol Latecki) [14:55:45] Diff URL: https://github.com/spdk/spdk/compare/9c8435b64968...85ba606943ef [14:55:45] *** Parts: travis-ci (~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com) () [14:58:52] *** Joins: travis-ci (~travis-ci@ec2-54-146-139-62.compute-1.amazonaws.com) [14:58:53] (spdk/master) vm_setup: add nvme-cli repo (Seth Howell) [14:58:53] Diff URL: https://github.com/spdk/spdk/compare/85ba606943ef...99850ca7d5cb [14:58:53] *** Parts: travis-ci (~travis-ci@ec2-54-146-139-62.compute-1.amazonaws.com) () [15:21:18] *** Joins: travis-ci (~travis-ci@ec2-54-234-233-236.compute-1.amazonaws.com) [15:21:19] (spdk/v18.07.1) Update 18.07.1 Changelog (Ben Walker) [15:21:19] Diff URL: https://github.com/spdk/spdk/compare/v18.07.1 [15:21:19] *** Parts: travis-ci (~travis-ci@ec2-54-234-233-236.compute-1.amazonaws.com) () [15:49:58] *** Quits: bwalker (~bwalker@134.134.139.72) (ZNC - http://znc.in) [15:54:31] *** Joins: bwalker (bwalker@nat/intel/x-ltztyiskcxybmjyq) [15:54:31] *** Server sets mode: +cnrt [15:54:31] *** Server sets mode: +cnrt [15:54:31] *** ChanServ sets mode: +o bwalker [16:00:32] *** Joins: jimharris (jimharris@nat/intel/x-mxwpictqicnzpuph) [16:00:32] *** ChanServ sets mode: +o jimharris