[00:00:59] *** Joins: tomzawadzki (~tomzawadz@192.55.54.45) [00:58:33] *** Joins: klateck (~klateck@134.134.139.72) [00:58:42] *** Parts: klateck (~klateck@134.134.139.72) ("Leaving") [00:59:03] *** Joins: klateck (~klateck@134.134.139.72) [06:31:40] *** Quits: tomzawadzki (~tomzawadz@192.55.54.45) (Ping timeout: 252 seconds) [07:09:01] *** Joins: sherlock1122_ (~sherlock1@119.167.96.147) [07:43:49] pwodkowx: if you have a few minutes, could you review the other patches in this series? https://review.gerrithub.io/#/c/spdk/spdk/+/424582/ They are all RPC/config related. [07:47:51] https://review.gerrithub.io/#/c/spdk/spdk/+/417292/ build failed with error "modprobe: FATAL: Module ib_ucm not found in directory /lib/modules/4.17.19-200.fc28.x86_64" [07:48:03] Looks like the fedora-09 VM is missing ib module [07:48:52] hi jkkariu: this issue has been fixed, you'll need to rebase your patch on latest master [07:48:56] ib_ucm is no longer a module in 4.17.x [07:49:04] ok [07:49:22] I will rebase it [09:03:02] *** Joins: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) [09:03:03] (spdk/master) lvol: move null check from verify_lvol_name (Seth Howell) [09:03:03] Diff URL: https://github.com/spdk/spdk/compare/106218144363...49911660c75a [09:03:03] *** Parts: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) () [09:05:01] *** Joins: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) [09:05:01] (spdk/master) thread: Fix issue where a channel would be destroyed twice (Ben Walker) [09:05:01] Diff URL: https://github.com/spdk/spdk/compare/49911660c75a...399a38a54176 [09:05:01] *** Parts: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) () [09:07:07] *** Joins: travis-ci (~travis-ci@ec2-54-82-69-192.compute-1.amazonaws.com) [09:07:08] (spdk/master) Merge branch 'master' of https://github.com/spdk/spdk (xxks-kkk) [09:07:08] Diff URL: https://github.com/xxks-kkk/spdk/compare/fb49c429de72...48726cf25794 [09:07:08] *** Parts: travis-ci (~travis-ci@ec2-54-82-69-192.compute-1.amazonaws.com) () [09:38:20] *** Quits: sherlock1122_ (~sherlock1@119.167.96.147) (Remote host closed the connection) [10:24:46] *** Joins: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) [10:24:46] (spdk/master) test/unit: fix scan-build error in pmem ut (Seth Howell) [10:24:46] Diff URL: https://github.com/spdk/spdk/compare/399a38a54176...11a6ed238b0b [10:24:46] *** Parts: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) () [11:10:48] *** Joins: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) [11:10:49] (spdk/master) nvmf: Require qpair disconnect to be performed from owning thread (Ben Walker) [11:10:49] Diff URL: https://github.com/spdk/spdk/compare/3f229f0e46cd...fd948954329e [11:10:49] *** Parts: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) () [11:19:15] jimharris: I see good progress in https://review.gerrithub.io/#/c/spdk/spdk/+/424061/ [11:19:24] I think I will be abble to reuse this client lib in loading JSON config [11:19:49] ah - yes, i hadn't drawn that connection yet [11:20:16] but one question about lib/rpc_client/* part [11:20:18] yeah, overall it's looking really good [11:21:17] will this open a way to any arbitrary RPC or we want to mirror all server RPC methods there ? [11:21:47] * to execut any RPC :) [12:19:00] pwodkowx: i'm not sure yet - i feel like trying to mirror all of the RPCs would be a ton of work, so maybe we add them as we need them? [12:19:48] but in general i think the existing jsonrpc library should support any arbitrary RPC, and the new "rpc_client" library can add wrappers for specific SPDK RPCs [12:21:18] tons of work is gently spoken xD [12:22:50] I would rather keep this generic without any RPC mirrored from server side. [12:24:57] for xiaodong's use case, he wants to use this to do nvme passthru commands from various configuration/management/testing applications [12:25:21] so they will all need some kind of understanding of the RPCs required to do that [12:25:21] If we need some client API RPC inside SPKD library itself lets do it but keep it internal and don't expose any of them till there will be real need from us or users. Otherwise we can open real Pandora box. [12:25:24] so the "rpc_client" library is effectively making that code common, so multiple applications can use it [12:25:51] i'm saying that there is a real need from us [12:25:58] for example, nvme-cli could use this [12:26:51] sure, but look at _spdk_rpc_client_check_rpc_method [12:28:54] i agree with your comment on that - anything in this rpc_client library should exactly match an SPDK RPC - i.e. spdk_rpc_client_get_rpc_methods [12:29:01] the get_rpc_methods RPC method is one of the simples one we have. But even that the _spdk_rpc_client_check_rpc_method() is not relecting its behaviour. [12:29:23] as there is optional parameter. [12:30:53] *** Joins: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) [12:30:53] (spdk/master) bdev/rbd: fix memory leak and spdk_io_device_register fail (Li Feng) [12:30:53] Diff URL: https://github.com/spdk/spdk/compare/fd948954329e...3f6a54c1a7dc [12:30:53] *** Parts: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) () [12:31:36] maybe from other side - what set of RPC call will be needed in what-ever-configuration/management/testing applications we are inventing? [12:32:29] most of the nvme-related ones, plus a couple in the patch xiaodong has after this one we are discussing here [12:32:55] i would be ok with deferring the rpc_client library for now [12:33:09] maybe we can do them separately (in apps) to judge if we really need them in library [12:33:25] put code to test the get_rpc_methods RPC in the test code for now [12:33:34] and then look later at what belongs in a 'helper' library to enable management apps [12:34:04] yup, +1 from [12:37:27] *** Joins: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) [12:37:28] (spdk/master) nbd: Encapsulate spdk_event usage in subsystem module (Ben Walker) [12:37:29] Diff URL: https://github.com/spdk/spdk/compare/3f6a54c1a7dc...5bc5f864089b [12:37:29] *** Parts: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) () [12:44:00] sethhowe: jimharris: do we now have a build/test in the CI pool that verifies successful build with "--with-shared" ? I just did a pull and tried to build and got a couple undefined references. [12:44:03] libspdk_bdev.so: undefined reference to `_spdk_trace_record' [12:44:44] libspdk_bdev.so: undefined reference to `g_trace_histories' [12:46:02] uh, i guess not - you can blame yours truly for those new error messages :( [12:46:06] I suspect something changed necessitating an amendment to shared_lib/spdk.map [12:46:33] i'll take a look - thanks for the report [12:47:33] Thx Jim ! [12:49:42] *** Joins: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) [12:49:43] (spdk/master) iscsi, nvmf, vhost: remove default config file pathnames (Jim Harris) [12:49:43] Diff URL: https://github.com/spdk/spdk/compare/5bc5f864089b...b6ee6f9241de [12:49:43] *** Parts: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) () [13:06:43] *** Joins: travis-ci (~travis-ci@ec2-54-211-108-86.compute-1.amazonaws.com) [13:06:43] (spdk/master) Merge branch 'master' of https://github.com/spdk/spdk (xxks-kkk) [13:06:43] Diff URL: https://github.com/xxks-kkk/spdk/compare/48726cf25794...baa4a47f319a [13:06:43] *** Parts: travis-ci (~travis-ci@ec2-54-211-108-86.compute-1.amazonaws.com) () [13:10:15] jimharris: Adding those two entries to the spdk.map resolved the shared lib build. Shall I submit the patch for that, or would you prefer to look into this further? [13:10:46] i have a patch ready for it [13:10:46] i'm also fixing up some dependencies issues i found while debugging this [13:11:16] we need examples/app/test to depend on shared_lib (not lib) when CONFIG_SHARED=y [13:13:17] i'll have them pushed here in a sec [13:14:18] series of three patches starts at https://review.gerrithub.io/#/c/spdk/spdk/+/424721/ [13:27:25] Cool, and thx. Shall we create a Trello card or maybe github issue to augment the CI pool with a "--with-shared" build? [13:30:56] github issue [13:30:59] i suspect seth or karol will be on it immediately [13:31:27] but having the github issue will make sure it gets tracked [13:48:36] *** Joins: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) [13:48:36] (spdk/v18.07.x) nvme: add quirk for Intel SSDs without vendor-specific log pages (Jim Harris) [13:48:36] Diff URL: https://github.com/spdk/spdk/compare/716ad0e389c3...44a43939e84b [13:48:36] *** Parts: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) () [15:00:01] *** Joins: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) [15:00:02] (spdk/master) nvme: make nvme_ctrlr_start() static and can return correct errno (Changpeng Liu) [15:00:17] Diff URL: https://github.com/spdk/spdk/compare/c8337cb68a18...7c0e9faa07e4 [15:00:17] *** Parts: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) () [15:01:28] *** Joins: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) [15:01:29] (spdk/master) bdev/lvol: _create_lvol_disk(): unregister disk if something wrong (wuzhouhui) [15:01:29] Diff URL: https://github.com/spdk/spdk/compare/7c0e9faa07e4...823a9960b961 [15:01:29] *** Parts: travis-ci (~travis-ci@ec2-184-73-24-174.compute-1.amazonaws.com) () [15:04:50] *** Joins: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) [15:04:50] (spdk/master) autotest: testing of nested lvol should be retained (xuhuagen) [15:04:50] Diff URL: https://github.com/spdk/spdk/compare/823a9960b961...5dcb2c4678a1 [15:04:50] *** Parts: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) () [15:18:11] *** Joins: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) [15:18:27] (spdk/master) scripts/pkgdep.sh: distinguish Fedora, CentOS and RHEL (Pawel Wodkowski) [15:18:27] Diff URL: https://github.com/spdk/spdk/compare/5dcb2c4678a1...8cf4a7af05b5 [15:18:27] *** Parts: travis-ci (~travis-ci@ec2-54-161-220-70.compute-1.amazonaws.com) () [18:30:52] *** Quits: guerby (~guerby@april/board/guerby) (Remote host closed the connection) [18:33:42] *** Joins: guerby (~guerby@april/board/guerby) [20:32:57] *** Quits: guerby (~guerby@april/board/guerby) (Remote host closed the connection) [20:35:24] *** Joins: guerby (~guerby@april/board/guerby) [21:38:56] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97)