[04:05:35] *** Quits: tomzawadzki (~tomzawadz@134.134.139.72) (Remote host closed the connection) [05:56:01] *** Joins: pzedlews_ (~pzedlews@192.55.54.38) [06:20:34] *** Quits: pzedlews_ (~pzedlews@192.55.54.38) (Quit: Leaving) [08:25:19] *** Joins: tkulasek (~tkulasek@134.134.139.72) [09:28:20] *** Joins: travis-ci (~travis-ci@ec2-184-73-70-222.compute-1.amazonaws.com) [09:28:21] (spdk/master) sock: fix socket memory free (Tomasz Kulasek) [09:28:22] Diff URL: https://github.com/spdk/spdk/compare/2b3abb2a339c...349f43c2fcf1 [09:28:22] *** Parts: travis-ci (~travis-ci@ec2-184-73-70-222.compute-1.amazonaws.com) () [09:52:40] *** Quits: tkulasek (~tkulasek@134.134.139.72) (Ping timeout: 244 seconds) [09:53:43] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [10:32:21] *** Joins: pwodkowx (pwodkowx@nat/intel/x-bobehuvddjgriyvs) [12:26:18] jimharris: Hi Jim, I pushed a patch altering the build of the shared_lib, https://review.gerrithub.io/#/c/spdk/spdk/+/421936/ The test pool is reporting a failure, but I don't comprehend it: https://ci.spdk.io/spdk-jenkins/results/autotest-per-patch/builds/9163/archive/unittest_autotests/build.log [12:27:50] it looks like build/lib/libspdk.so.0.0.0 (or some wildcard matching that) needs to be added to a .gitignore file [12:27:54] Generated files missing from .gitignore: [12:27:55] 15:07:22 $ git status --porcelain [12:27:55] ?? build/lib/libspdk.so.0.0.0 [12:28:25] Ah, didn't know that a newly created build artifact needed to get added to the .gitignore. Thanks. [12:30:22] looks like the top level .gitignore has *.so, but should probably add *.so.* as well [12:30:49] Right. Amending now... [12:31:48] wondering if these rules should go into a build/.gitignore instead? we used to scatter the *.a files across the different lib/* directories, but we consolidated them into build/lib a while ago [12:32:03] for now just adding a rule to the top level .gitignore is fine [12:49:46] jimharris: Dang, the ln command for BSD apparently has different options that used in Linux (ugh). Do you happen to know the equivalent of the '-r' (relative) in Linux for BSD? [12:53:29] How to achieve Linux's '-r' option isn't readily apparent in https://www.freebsd.org/cgi/man.cgi?ln [13:07:31] let me bring up my FreeBSD VM [13:14:02] can you describe why you need -r on Linux? [13:14:55] because you want to specify the full path and let the OS determine the relative path? [13:15:13] i don't think FreeBSD ln supports this [13:15:31] It allows one to create a relative symlink which is the convention in a Linux library directory; e.g. libspdk.so -> libspdk.so.0.0.0 [13:16:02] if you just specify relative paths using ln -s, it should work [13:16:18] That's the convention. They do not use absolute links; i.e. it does NOT look like: libspdk.so -> /usr/local/lib/libs;dk.so.0.0.0 [13:16:32] right [13:16:34] jimharris: yes, that's true, but only if you change directories to the target dir first. [13:16:46] with the '-r' option in Linux, you don't have to change directories. [13:16:55] It figures out the names relative to the source. [13:18:29] Sorry for the typo's. I have a dog sitting in my lap that I just recently rescued from the shelter, and another dog nosing my arm repeatedly for an early dinner ;-) [13:18:38] i don't see a FreeBSD equivalent to this -r option [13:18:43] no worries :) [13:19:30] I didn't see how to do it either when I google'd FreeBSD's man page for ln. (ugh). [13:20:40] On your FreeBSD VM, can you verify that they're using relative symlinks in their lib directories between a .so and a specific version'd lib? [13:20:52] Just like they do in Linux? [13:21:41] yes - they are relative [13:22:46] hmmm - well, no not all of them are [13:23:21] i can't make heads or tails of why some are and some aren't [13:23:40] let me dig around build scripts - this VM has the full FreeBSD source tree downloaded [13:25:57] ah - FreeBSD uses install, not ln [13:26:02] *** Joins: alekseymmm_ (050811aa@gateway/web/freenode/ip.5.8.17.170) [13:26:05] install -l rs [13:26:55] yep - that does it; so you can do: [13:27:00] touch /tmp/foo [13:27:05] install -l rs /tmp/foo /tmp/bar [13:28:39] Hmmm. I really need to install a FreeBSD VM so I can test a change with a make-ifeq around OS's. TGIF ! [13:32:32] I'm now reading that the shared library versioning convention for BSD is a little different from Linux too (sigh). The Linux final suffix (release) I think is optional so maybe I should just drop it and that way it would appear the same between Linux and BSD. [13:34:43] Per https://www.freebsd.org/doc/en/books/developers-handbook/policies-shlib.html, FreeBSD states as one of the "principles" that the versioning should begin with 1.0. In my initial commit, I began with 0.0.0. That's easy to change at this point, esp. given that we're not guaranteeing ABI compatibility or anything with respect to the version. Right now, I'm just trying to get us using the proper naming. [14:15:34] would anyone have any issue with me changing the mailing list settings to automatically convert mail to plain text? [15:38:25] *** Quits: darsto (~darsto@89-68-111-146.dynamic.chello.pl) (Ping timeout: 248 seconds) [15:57:57] *** Joins: darsto (~darsto@89-68-111-146.dynamic.chello.pl) [16:21:51] *** Quits: alekseymmm_ (050811aa@gateway/web/freenode/ip.5.8.17.170) (Quit: Page closed) [20:09:50] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Quit: Leaving.)