[01:19:33] i was wondering how vhost-blk hotremove works [01:20:02] we don't wait on any pending I/O in the hotremove callback, we just call spdk_bdev_close() right away [01:20:39] but - we keep the i/o channel open, and that prevents the bdev from being removed [01:38:21] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 252 seconds) [02:50:57] *** Quits: vermavis (vermavis@nat/intel/x-ujoievgnpzwzabbv) (Quit: ZNC - http://znc.in) [02:51:11] *** Joins: vermavis (vermavis@nat/intel/x-piukkzssoycvibyr) [04:10:53] *** Joins: Shuhei (72a3ed06@gateway/web/freenode/ip.114.163.237.6) [04:14:09] *** Joins: Shuhei_ (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [04:16:52] *** Joins: lyan (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) [04:17:15] *** lyan is now known as Guest87858 [04:21:54] and Changpeng, Gang, I will be out of the office tomorrow and it will be hard to work enough. Sorry for inconvenience. [04:23:35] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 240 seconds) [04:25:32] Shuhei: done [04:27:16] Darek, Thank you. [04:27:21] I'll hold back with giving it +1 though [04:27:54] the open() callback must be handled in a specific way and that's not even documented anywhere [04:28:04] but let's fix iscsi first [04:28:10] that's the priority [04:33:15] *** Quits: Shuhei (72a3ed06@gateway/web/freenode/ip.114.163.237.6) (Ping timeout: 252 seconds) [04:36:00] *** Quits: Shuhei_ (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 252 seconds) [05:00:14] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [05:01:40] darsto: thank you, nice point. I'll add document. [05:25:30] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 252 seconds) [05:37:17] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [05:47:10] darsto: About your comments hours ago, I feel that iscsi hotplug will take similar policy. that is very helpful to learn more. thank you. [05:47:17] *** Quits: tomzawadzki (tomzawadzk@nat/intel/x-odgpvwdqqtqvzulh) (Quit: Leaving) [05:54:06] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 252 seconds) [06:17:35] *** Joins: bwalker (bwalker@nat/intel/x-xzgimfuqbvzqevsi) [06:17:35] *** Server sets mode: +cnt [06:17:56] *** Joins: changpe1 (changpe1@nat/intel/x-lojzsoolviiarjwl) [06:18:52] *** Joins: jstern (jstern@nat/intel/x-kkcxshfjxqrwxnsg) [06:19:22] *** Joins: gangcao (~gangcao@134.134.139.72) [06:23:55] *** Joins: peluse (peluse@nat/intel/x-iixjqlufuwwutfqk) [06:25:24] *** Joins: pwodkowx (~pwodkowx@134.134.139.72) [06:25:56] *** Joins: pzedlews (~pzedlews@134.134.139.72) [06:28:42] *** Joins: cunyinch (~cunyinch@134.134.139.72) [06:34:31] *** Joins: qdai2 (qdai2@nat/intel/x-ergsgbgowlkxakgc) [06:35:01] *** Joins: tsg (~tsg@134.134.139.72) [06:38:04] *** Joins: klateck (~klateck@134.134.139.72) [06:39:40] *** Joins: pawelkax (~pawelkax@134.134.139.72) [06:40:05] *** Joins: pbshah1 (~pbshah1@134.134.139.72) [06:41:05] *** Joins: ppelplin (~ppelplin@134.134.139.72) [06:41:36] *** Joins: vermavis (~vermavis@134.134.139.72) [06:42:06] *** Joins: ziyeyang (~ziyeyang@134.134.139.72) [06:44:39] *** Joins: mszwed (mszwed@nat/intel/x-wuuqymyjqocfuvrx) [06:47:09] *** Joins: lgalkax (lgalkax@nat/intel/x-fsygzsppcgttkhru) [06:48:40] *** Joins: jimharris (~jimharris@134.134.139.72) [06:51:43] *** Joins: kjakimia (kjakimia@nat/intel/x-frigbwgrvduewfov) [06:52:47] *** Joins: pniedzwx (~pniedzwx@134.134.139.72) [07:03:46] *** Joins: johnmeneghini (~johnmeneg@216.240.30.5) [07:04:09] *** Joins: philipp-sk (~Philipp@ktnron0916w-lp130-02-76-66-162-159.dsl.bell.ca) [07:34:59] *** Joins: bwalker (bwalker@nat/intel/x-vqhfcpoxhpyrgrya) [07:34:59] *** Server sets mode: +cnt [07:37:31] *** Joins: jstern (~jstern@134.134.139.72) [07:37:57] *** Joins: kjakimia (kjakimia@nat/intel/x-majmnjjpxjynmfkc) [07:38:45] *** Quits: johnmeneghini (~johnmeneg@216.240.30.5) (Quit: Leaving.) [07:38:58] *** Joins: lgalkax (~lgalkax@134.134.139.72) [07:41:00] *** Joins: peluse (~peluse@134.134.139.72) [07:44:39] *** Joins: vermavis (~vermavis@134.134.139.72) [07:45:32] *** Joins: changpe1 (changpe1@nat/intel/x-obwdekbmxdnmbnsu) [07:47:08] *** Joins: jimharris (jimharris@nat/intel/x-nxedwjwqmahpseoz) [07:48:03] *** Joins: mszwed (~mszwed@134.134.139.72) [07:48:34] *** Joins: pawelkax (~pawelkax@134.134.139.72) [07:49:04] *** Joins: pbshah1 (~pbshah1@134.134.139.72) [07:49:34] *** Joins: pniedzwx (pniedzwx@nat/intel/x-dmxhhnrxgzysqisx) [07:51:36] *** Joins: qdai2 (qdai2@nat/intel/x-fvzhijdcknusziji) [07:52:06] *** Joins: tsg (~tsg@134.134.139.72) [07:53:07] *** Joins: cunyinch (cunyinch@nat/intel/x-iwryzhkgaijjzeco) [07:54:12] *** Joins: ppelplin (~ppelplin@134.134.139.72) [07:55:21] *** ChanServ sets mode: +o jimharris [07:55:38] *** Joins: ziyeyang (~ziyeyang@134.134.139.72) [07:56:12] *** Joins: klateck (klateck@nat/intel/x-cpkpntuykdrvkyei) [07:57:40] *** Joins: pzedlews (pzedlews@nat/intel/x-drmhpbthnjgnkrpe) [09:00:30] *** Joins: peter_turschm (~peter_tur@2604:4080:1133:0:95ab:d636:8aaa:c628) [09:04:02] *** Quits: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) (Quit: My MacBook has gone to sleep. ZZZzzz…) [09:13:38] sethhowe_, klateck: looks like we've switched over? [09:14:14] *** ChanServ sets mode: +o bwalker [09:14:54] Yep, A couple of hiccups this morning, but we got everything switched over. I will restart the chandler pool here in a second. I am just running a quick batch query to make sure we don't rerun any builds we don't need to. [09:19:02] i like having the chandler pool adding its vote as a code-review [09:20:15] it looks like all of the open spdk reviews got a new +1 vote from the chandler pool? [09:50:29] *** Quits: tkulasek (~tkulasek@134.134.139.83) (Ping timeout: 260 seconds) [09:52:25] *** Quits: peter_turschm (~peter_tur@2604:4080:1133:0:95ab:d636:8aaa:c628) (Remote host closed the connection) [10:12:23] *** Joins: peter_turschm (~peter_tur@66.193.132.66) [10:15:10] *** Quits: peter_turschm (~peter_tur@66.193.132.66) (Client Quit) [10:41:44] *** Joins: johnmeneghini (~johnmeneg@216.240.30.5) [11:15:38] *** Quits: johnmeneghini (~johnmeneg@216.240.30.5) (Quit: Leaving.) [11:59:41] *** Joins: johnmeneghini (~johnmeneg@216.240.30.5) [12:29:34] *** Quits: johnmeneghini (~johnmeneg@216.240.30.5) (Quit: Leaving.) [12:40:43] *** Joins: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) [15:56:50] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [15:58:33] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Client Quit) [15:59:21] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [16:40:25] *** Quits: Guest87858 (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) (Quit: Leaving) [17:06:35] *** Joins: Shuhei (b6fb2f0e@gateway/web/freenode/ip.182.251.47.14) [17:11:09] *** Quits: Shuhei (b6fb2f0e@gateway/web/freenode/ip.182.251.47.14) (Ping timeout: 252 seconds) [17:12:56] *** Joins: Shuhei (b6fb2f0e@gateway/web/freenode/ip.182.251.47.14) [17:14:54] Hi Jim, I’m out of office now, I’ll try feedback to hotplug test later today in my time zone. Please wait shortly. [17:19:24] *** Quits: Shuhei (b6fb2f0e@gateway/web/freenode/ip.182.251.47.14) (Ping timeout: 252 seconds) [18:51:39] *** Joins: dlw (~Thunderbi@114.255.44.143) [19:49:47] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Quit: Leaving.) [20:35:38] *** Quits: philipp-sk (~Philipp@ktnron0916w-lp130-02-76-66-162-159.dsl.bell.ca) (Ping timeout: 268 seconds) [23:42:13] *** Joins: dlw1 (~Thunderbi@114.255.44.143) [23:42:14] *** Quits: dlw (~Thunderbi@114.255.44.143) (Read error: Connection reset by peer) [23:42:14] *** dlw1 is now known as dlw