[00:19:58] *** Joins: travis-ci (~travis-ci@ec2-54-198-68-202.compute-1.amazonaws.com) [00:19:59] (spdk/master) doc: add output directory to .gitignore (Jim Harris) [00:19:59] Diff URL: https://github.com/spdk/spdk/compare/81bb01c95948...ef1402a0f05c [00:19:59] *** Parts: travis-ci (~travis-ci@ec2-54-198-68-202.compute-1.amazonaws.com) () [00:24:45] *** Joins: tkulasek (tkulasek@nat/intel/x-ehmmdjhwsdhsvqmj) [00:28:26] *** Joins: tkulasek_ (~tkulasek@134.134.139.72) [00:31:01] *** Quits: tkulasek (tkulasek@nat/intel/x-ehmmdjhwsdhsvqmj) (Ping timeout: 256 seconds) [00:31:48] *** Joins: travis-ci (~travis-ci@ec2-23-20-128-48.compute-1.amazonaws.com) [00:31:49] (spdk/master) bdev: change spdk_bdev_free_io return type to void (Jim Harris) [00:31:49] Diff URL: https://github.com/spdk/spdk/compare/ef1402a0f05c...ddc63f077a62 [00:31:49] *** Parts: travis-ci (~travis-ci@ec2-23-20-128-48.compute-1.amazonaws.com) () [01:32:36] *** Joins: sethhowe_ (~sethhowe@134.134.139.75) [01:33:28] *** Quits: sethhowe (~sethhowe@192.55.54.38) (Remote host closed the connection) [02:41:18] *** Joins: dlw1 (~Thunderbi@114.255.44.143) [02:41:18] *** Quits: dlw (~Thunderbi@114.255.44.143) (Read error: Connection reset by peer) [02:41:19] *** dlw1 is now known as dlw [03:15:28] jimharris: why was this merged? https://review.gerrithub.io/c/spdk/spdk/+/410532 [03:15:34] was there any pressure on these tests? [03:51:59] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 256 seconds) [04:59:57] *** Quits: tkulasek_ (~tkulasek@134.134.139.72) (Ping timeout: 240 seconds) [05:34:54] *** Joins: lyan (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) [05:46:24] *** Joins: dlw (~Thunderbi@123.122.70.2) [06:39:25] *** Joins: tkulasek_ (tkulasek@nat/intel/x-gkgxkfalubpgksqn) [07:21:14] *** Quits: dlw (~Thunderbi@123.122.70.2) (Quit: dlw) [08:13:51] darsto: I must have missed your -1 when I merged it - I take a -1 from you on anything vhost-related pretty seriously [08:14:34] do you think we need to revert? or can you follow up with Chen (and Cc Changpeng) on the changes you'd like to see? [08:15:09] of course if you're busy (like watching World Cup or something) you can do it later :-) [08:17:32] I need to remove all those unit tests anyway. With the upcoming vhost changes it will be easier to rewrite them from scratch rather than refactoring what's already there [08:21:22] jimharris: These unit tests don't really test much. I wouldn't be surprised if they're all broken and only give us false assumptions something in vhost in working, while it's not. [08:21:41] *** Joins: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) [08:21:42] (spdk/master) string: escape references to \r and \n (Jim Harris) [08:21:43] Diff URL: https://github.com/spdk/spdk/compare/ddc63f077a62...cccc940efa65 [08:21:43] *** Parts: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) () [08:23:46] my ISP is playing tricks on me again. I don't think this message was sent: [08:23:48] "jimharris: These unit tests don't really test much. I wouldn't be surprised if they're all broken and only give us false assumptions something in vhost in working, while it's not." [08:26:23] i got it the first time [09:33:39] *** Quits: lyan (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) (Remote host closed the connection) [10:34:26] *** Joins: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) [10:34:27] (spdk/master) doc/Makefile: include mk/spdk.common.mk (Jim Harris) [10:34:27] Diff URL: https://github.com/spdk/spdk/compare/cccc940efa65...f387d3213385 [10:34:27] *** Parts: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) () [11:31:33] *** Quits: tkulasek_ (tkulasek@nat/intel/x-gkgxkfalubpgksqn) (Ping timeout: 256 seconds) [12:59:23] *** Quits: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) (Remote host closed the connection) [13:38:14] *** Joins: travis-ci (~travis-ci@ec2-54-198-36-28.compute-1.amazonaws.com) [13:38:15] (spdk/master) shared_lib: only export spdk_* symbols (Daniel Verkamp) [13:38:15] Diff URL: https://github.com/spdk/spdk/compare/f387d3213385...9259324ffb9a [13:38:15] *** Parts: travis-ci (~travis-ci@ec2-54-198-36-28.compute-1.amazonaws.com) () [13:39:09] the last two doxygen patches are ready https://review.gerrithub.io/#/c/spdk/spdk/+/416034/ [13:46:11] *** Joins: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) [13:46:12] (spdk/master) bdev: add delete_aio_bdev call (Tomasz Zawadzki) [13:46:12] Diff URL: https://github.com/spdk/spdk/compare/9259324ffb9a...96e93bd8d52f [13:46:12] *** Parts: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) () [14:25:58] *** Joins: travis-ci (~travis-ci@ec2-54-198-36-28.compute-1.amazonaws.com) [14:25:59] (spdk/master) autobuild.sh: fail build if Doxygen warnings found (Jim Harris) [14:25:59] Diff URL: https://github.com/spdk/spdk/compare/96e93bd8d52f...21d2dac7eebd [14:25:59] *** Parts: travis-ci (~travis-ci@ec2-54-198-36-28.compute-1.amazonaws.com) () [14:35:11] jimharris: as a short-term solution for https://github.com/spdk/spdk/issues/334 (astyle on ubuntu 16), I think we should uninstall astyle on that test machine [14:35:22] and then we can develop a better fix with astyle version detection [14:35:28] any heartburn with that approach? [14:44:16] sounds good [15:34:06] jimharris: looks like the doxygen warnings-as-errors thing is failing on Jenkins now [15:34:14] I guess it's just missing graphviz [15:50:39] makes sense - i'll ping Karol [16:36:42] *** Joins: travis-ci (~travis-ci@ec2-54-198-36-28.compute-1.amazonaws.com) [16:36:43] (spdk/master) nvme: add path status codes (TP 4028) (Daniel Verkamp) [16:36:44] Diff URL: https://github.com/spdk/spdk/compare/5e9dbb5e9274...5df15facd2d3 [16:36:44] *** Parts: travis-ci (~travis-ci@ec2-54-198-36-28.compute-1.amazonaws.com) () [17:22:08] *** Joins: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) [17:22:09] (spdk/master) test/config: Call pkgdep.sh from vm_setup (Seth Howell) [17:22:10] Diff URL: https://github.com/spdk/spdk/compare/5df15facd2d3...714776c02874 [17:22:10] *** Parts: travis-ci (~travis-ci@ec2-54-80-145-236.compute-1.amazonaws.com) () [17:51:16] *** Joins: lyan (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) [18:29:51] *** Joins: dlw (~Thunderbi@114.255.44.143) [20:42:04] *** Quits: lyan (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) (Remote host closed the connection) [20:47:51] *** Quits: nKumar (sid239884@gateway/web/irccloud.com/x-hiqvqekszxptbwez) (Ping timeout: 240 seconds) [22:24:42] *** Joins: nKumar (sid239884@gateway/web/irccloud.com/x-vabssoravpxccula) [22:58:34] *** Quits: nKumar (sid239884@gateway/web/irccloud.com/x-vabssoravpxccula) (Ping timeout: 256 seconds) [23:24:41] *** Joins: nKumar (sid239884@gateway/web/irccloud.com/x-vlrtzrsjbeojxrev)