[00:49:20] *** Joins: tkulasek (tkulasek@nat/intel/x-zcrqpshkrqsktvzf) [01:13:50] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [02:08:47] *** Joins: dlw1 (~Thunderbi@114.255.44.139) [02:10:27] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 240 seconds) [02:10:28] *** dlw1 is now known as dlw [02:42:57] *** Quits: dlw (~Thunderbi@114.255.44.139) (Ping timeout: 248 seconds) [02:54:51] *** Quits: darsto (~darsto@89-68-112-135.dynamic.chello.pl) (Ping timeout: 268 seconds) [02:55:14] *** Joins: darsto (~darsto@89-68-112-135.dynamic.chello.pl) [02:58:51] *** Joins: dlw (~Thunderbi@114.255.44.139) [03:20:21] *** Quits: dlw (~Thunderbi@114.255.44.139) (Ping timeout: 240 seconds) [03:28:52] *** Joins: dlw (~Thunderbi@114.255.44.139) [03:52:49] *** Quits: dlw (~Thunderbi@114.255.44.139) (Ping timeout: 268 seconds) [03:54:33] *** Joins: dlw (~Thunderbi@114.255.44.143) [04:00:57] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 240 seconds) [07:54:54] *** Joins: tomzawadzki (~tomzawadz@192.55.54.44) [08:13:03] *** Quits: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) (Quit: Textual IRC Client: www.textualapp.com) [08:17:27] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [08:17:28] (spdk/master) nvmf: fix Identify Namespace for inactive NSIDs (Daniel Verkamp) [08:17:28] Diff URL: https://github.com/spdk/spdk/compare/47c7470dbf78...a35b1eb6ab6c [08:17:28] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [08:20:09] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [08:20:10] (spdk/master) nvmf: Do not allow NN to change while connections present (Ben Walker) [08:20:10] Diff URL: https://github.com/spdk/spdk/compare/a35b1eb6ab6c...1e481d0438e6 [08:20:10] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [09:03:28] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [09:37:27] jimharris: ping on https://review.gerrithub.io/#/c/spdk/spdk/+/412859/ - this finishes up the fix for issue #303 [09:41:02] *** Joins: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) [09:41:03] (spdk/master) jsonrpc: make "jsonrpc" actually optional (Daniel Verkamp) [09:41:03] Diff URL: https://github.com/spdk/spdk/compare/1e481d0438e6...da7673f71f15 [09:41:03] *** Parts: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) () [09:42:05] *** Joins: travis-ci (~travis-ci@ec2-54-161-181-102.compute-1.amazonaws.com) [09:42:06] (spdk/master) nvme: remove stray backslash in comment (Daniel Verkamp) [09:42:06] Diff URL: https://github.com/spdk/spdk/compare/da7673f71f15...00a51646d03b [09:42:06] *** Parts: travis-ci (~travis-ci@ec2-54-161-181-102.compute-1.amazonaws.com) () [10:25:28] *** Joins: travis-ci (~travis-ci@ec2-54-161-181-102.compute-1.amazonaws.com) [10:25:29] (spdk/master) nvme: fail when request is too long (Piotr Pelplinski) [10:25:29] Diff URL: https://github.com/spdk/spdk/compare/00a51646d03b...fbf06aca1a63 [10:25:29] *** Parts: travis-ci (~travis-ci@ec2-54-161-181-102.compute-1.amazonaws.com) () [10:26:38] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [10:26:39] (spdk/master) test/vhost:Remove vhost configuration file from live migration test. (Pawel Niedzwiecki) [10:26:39] Diff URL: https://github.com/spdk/spdk/compare/fbf06aca1a63...89236d8fc86a [10:26:39] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [10:32:25] *** Joins: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) [10:32:26] (spdk/master) test/json: Fix: Add missing function declaration (Pawel Kaminski) [10:32:26] Diff URL: https://github.com/spdk/spdk/compare/be1c82b7a819...d34bd0a60bac [10:32:26] *** Parts: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) () [10:32:40] *** Joins: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) [10:32:41] (spdk/master) nvme: update the NS identify data according to AER (Changpeng Liu) [10:32:41] Diff URL: https://github.com/spdk/spdk/compare/89236d8fc86a...be1c82b7a819 [10:32:41] *** Parts: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) () [10:41:28] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [10:41:29] (spdk/master) nvmf: Add states to spdk_nvmf_qpair (Ben Walker) [10:41:29] Diff URL: https://github.com/spdk/spdk/compare/d34bd0a60bac...f14189b9a679 [10:41:29] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [10:43:33] *** Joins: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) [10:43:34] (spdk/master) doc/vhost_processing: replace the ASCII diagram with an SVG one (Dariusz Stojaczyk) [10:43:35] Diff URL: https://github.com/spdk/spdk/compare/f14189b9a679...026c69db1aab [10:43:35] *** Parts: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) () [11:18:38] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [11:18:39] (spdk/master) nvmf: remove unused #defines from nvmf_internal.h (Daniel Verkamp) [11:18:39] Diff URL: https://github.com/spdk/spdk/compare/026c69db1aab...98d140d2af53 [11:18:39] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [11:22:26] bwalker: looking at the spdk_bdev_io encapsulation patch - that has been needed for a long time [11:22:37] I just did the first data member [11:22:38] could we consider a third option? [11:22:40] and then put a task on trello [11:23:08] move the internal stuff into a data structure within spdk_bdev_io and clearly mark it as internal [11:24:29] i'm just afraid that the spdk_bdev_io <-> spdk_bdev_io_internal stuff will make bdev.c even harder to comprehend [11:24:30] so the definition is still visible, but through documentation the user knows not to access it? [11:24:39] yes [11:25:19] I'm ok with starting out with that strategy - it gets us organized at a minimum [11:25:40] maybe it's good enough ultimately [11:25:40] the naming could help too - i.e. bdev_io->internal.buf_link [11:25:57] of bdev_io->dont_touch_this.buf_link [11:26:01] of=>or [11:26:02] it won't work if we ever cared about ABI compatibility [11:26:11] I'm not sure we ever will [11:26:37] true [11:27:08] I'm fine with going that way for now [11:27:11] maybe drv has an opinion [11:27:20] pretty much what you guys already said [11:27:30] if we care about ABI compatibility, we'll have to do something like what bwalker proposed [11:27:37] but I'm OK either way [11:28:21] what if we change where the per-bdev-io context buffer goes? [11:28:29] I guess one advantage of moving things to the internal struct is that we only pay the code complexity cost for ABI compatibility when we actually do ABI compatibility [11:28:52] because you'd just switch to my strategy and move the internal struct when we go that way [11:31:02] i'm saying that the internal struct is still visible, but it goes to the end of spdk_bdev_io, and then the context buffer goes after that [11:31:18] doesn't that help with ABI compatibility? [11:32:37] hmm, I think that might work [11:33:19] it makes driver_ctx a dereference instead of a simple offset calculation but i'll bet it's noise in the end [11:33:43] yeah, that's probably clearer anyway [11:34:22] i can run some bdevperf benchmarks with the dereference to see if it's noticeable at all (I suspect it's not) [11:34:31] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:36:35] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:37:05] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:39:08] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:39:38] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:41:41] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:42:11] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:44:14] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:44:44] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:46:47] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:47:18] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:49:20] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:49:50] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:51:50] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:52:21] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:54:23] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:54:53] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:56:56] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:57:26] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [11:59:26] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [11:59:57] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [12:02:00] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [12:02:30] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [12:04:33] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [12:05:03] *** Joins: lhodev (~lhodev@inet-hqmc08-o.oracle.com) [12:06:35] *** Quits: tkulasek (tkulasek@nat/intel/x-zcrqpshkrqsktvzf) (Ping timeout: 240 seconds) [12:14:41] *** Quits: darsto (~darsto@89-68-112-135.dynamic.chello.pl) (Ping timeout: 248 seconds) [12:19:37] *** Joins: darsto (~darsto@89-68-112-135.dynamic.chello.pl) [12:41:54] People are asking for the WebEx recording of today's dynamic threading SPDK community meeting. I can send out the link, but I'd like to copy this WebEx recording out to a different location someplace. Do we have a Web space anyplace where we can keep this information? [13:24:01] *** Quits: darsto (~darsto@89-68-112-135.dynamic.chello.pl) (Ping timeout: 248 seconds) [13:28:36] *** Joins: darsto (~darsto@89-68-112-135.dynamic.chello.pl) [14:20:07] we can probably arrange that - we have storage on ci.spdk.io [14:20:09] for build logs [14:20:19] I'll talk to drv here in a minute [14:21:46] how big is it? [14:30:55] *** Quits: lhodev (~lhodev@inet-hqmc08-o.oracle.com) (Remote host closed the connection) [15:38:52] *** Joins: dlw (~Thunderbi@114.252.34.129) [15:51:16] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [15:55:48] not a few patches are queued. [15:56:01] https://review.gerrithub.io/#/c/spdk/spdk/+/403624/44 [15:57:26] drv: thanks for reviewing those patches. I fixed your feedback. So will you check them if your feedback is fixed. [16:24:27] *** Quits: tomzawadzki (~tomzawadz@192.55.54.44) (Remote host closed the connection) [16:34:56] Shuhei: I'll take a look now, thanks [16:37:10] drv: Thank you! [16:37:24] I think jimharris was planning on looking at the iSCSI conf patches soon too [16:37:40] yes [16:40:32] darsto: just FYI, DPDK 18.05 was tagged, and I have created the corresponding spdk-18.05 branch for spdk/dpdk [16:47:05] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [16:47:06] (spdk/master) test/nvme_ns_cmd: zero-initialize ctrlr options (Daniel Verkamp) [16:47:06] Diff URL: https://github.com/spdk/spdk/compare/98d140d2af53...9e9cd51f55ad [16:47:06] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [16:53:44] *** Quits: dlw (~Thunderbi@114.252.34.129) (Ping timeout: 244 seconds) [17:00:55] *** Joins: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) [17:00:56] (spdk/master) test/vhost: Remove vhost configuration file from integrity test (Pawel Niedzwiecki) [17:00:56] Diff URL: https://github.com/spdk/spdk/compare/9e9cd51f55ad...3dab6c957070 [17:00:56] *** Parts: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) () [17:10:27] *** Quits: darsto (~darsto@89-68-112-135.dynamic.chello.pl) (Ping timeout: 240 seconds) [17:15:38] *** Joins: darsto (~darsto@89-68-112-135.dynamic.chello.pl) [17:18:26] *** Joins: dlw (~Thunderbi@114.252.34.129) [17:36:47] *** Quits: dlw (~Thunderbi@114.252.34.129) (Ping timeout: 256 seconds) [18:04:03] *** Joins: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) [18:04:04] (spdk/master) iscsi: Solve the potential no io channel issue. (Ziye Yang) [18:04:04] Diff URL: https://github.com/spdk/spdk/compare/3dab6c957070...d10401cc0798 [18:04:04] *** Parts: travis-ci (~travis-ci@ec2-54-224-19-64.compute-1.amazonaws.com) () [18:12:04] *** Joins: dlw (~Thunderbi@114.255.44.143) [18:17:35] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [18:21:34] *** Quits: darsto (~darsto@89-68-112-135.dynamic.chello.pl) (Ping timeout: 244 seconds) [18:23:28] *** Quits: dlw (~Thunderbi@114.255.44.143) (Quit: dlw) [18:25:11] *** Joins: dlw (~Thunderbi@114.255.44.143) [18:26:50] *** Joins: darsto (~darsto@89-68-112-135.dynamic.chello.pl) [19:35:12] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 260 seconds) [20:09:22] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [20:37:27] *** Quits: darsto (~darsto@89-68-112-135.dynamic.chello.pl) (Ping timeout: 244 seconds) [20:42:37] *** Joins: darsto (~darsto@89-68-112-135.dynamic.chello.pl) [20:44:00] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [20:57:21] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [21:02:32] hi, today we have a meeting about github issues? [21:04:40] yes, in about 25 minutes [21:05:45] drv: I got it. thank you. [21:24:59] *** Quits: darsto (~darsto@89-68-112-135.dynamic.chello.pl) (Ping timeout: 244 seconds) [21:30:08] *** Joins: darsto (~darsto@89-68-112-135.dynamic.chello.pl) [21:31:02] the bug scrub meeting is starting now (webex link is on the mailing list) [22:54:08] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [22:54:09] (spdk/master) nvmf: refactor abort handling (Daniel Verkamp) [22:54:09] Diff URL: https://github.com/spdk/spdk/compare/d10401cc0798...85a822292d51 [22:54:09] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [22:56:05] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [22:56:06] (spdk/master) bdev/qos: queue and submit directly on same thread (GangCao) [22:56:06] Diff URL: https://github.com/spdk/spdk/compare/85a822292d51...c5f3ab7a733f [22:56:06] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) () [23:06:40] *** Joins: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) [23:06:41] (spdk/master) nvmf: allow abort of AER requests (Daniel Verkamp) [23:06:41] Diff URL: https://github.com/spdk/spdk/compare/c5f3ab7a733f...40b6f761b255 [23:06:41] *** Parts: travis-ci (~travis-ci@ec2-54-161-208-147.compute-1.amazonaws.com) ()