[02:39:42] *** Joins: tkulasek (tkulasek@nat/intel/x-lkdkwbooxzwrmoid) [03:58:14] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 250 seconds) [08:22:01] Hello maintainers, any idea when the patch https://review.gerrithub.io/#/c/spdk/spdk/+/407220/ will be merged? I am using that example in the SPDK Lab session on Wednesday [08:22:32] it's merged now :) [08:25:06] cool. Thanks Jim [08:25:40] *** Joins: travis-ci (~travis-ci@ec2-54-160-138-195.compute-1.amazonaws.com) [08:25:41] (spdk/master) examples/bdev: add hello world example (John Kariuki) [08:25:41] Diff URL: https://github.com/spdk/spdk/compare/0c7dc6524828...8b75f85f2d55 [08:25:41] *** Parts: travis-ci (~travis-ci@ec2-54-160-138-195.compute-1.amazonaws.com) () [08:35:12] jkkariu, well done!! [08:38:35] thanks paul [09:35:44] can I get another review on this one? https://review.gerrithub.io/#/c/spdk/spdk/+/409998/ [09:35:52] some other stuff needs to get rebased on top of that [10:11:17] *** Quits: tkulasek (tkulasek@nat/intel/x-lkdkwbooxzwrmoid) (Quit: Leaving) [10:28:39] *** Joins: travis-ci (~travis-ci@ec2-54-224-238-97.compute-1.amazonaws.com) [10:28:40] (spdk/master) scripts/check_format.sh: ban use of strcat() (Daniel Verkamp) [10:28:40] Diff URL: https://github.com/spdk/spdk/compare/ede6d97e3c68...2c200379f270 [10:28:40] *** Parts: travis-ci (~travis-ci@ec2-54-224-238-97.compute-1.amazonaws.com) () [10:36:23] *** Joins: travis-ci (~travis-ci@ec2-54-224-238-97.compute-1.amazonaws.com) [10:36:24] (spdk/master) bdev: rename bdev_module_channel to bdev_shared_resource (Dariusz Stojaczyk) [10:36:24] Diff URL: https://github.com/spdk/spdk/compare/2c200379f270...cc8bb51b24a1 [10:36:24] *** Parts: travis-ci (~travis-ci@ec2-54-224-238-97.compute-1.amazonaws.com) () [10:36:41] *** Joins: tomzawadzki (tomzawadzk@nat/intel/x-iddczysavjxgffqh) [10:55:16] ahh hell, you merged that last patch you asked for review on before I hit post, bwalker that is. No big deal though [10:55:56] maybe you can add a comment on others that you have that are building on top of it, just looking to add a little more commentary on what is shared and/or what it is that its shared between [10:56:14] (even if it seems obvious, it won't be to first time readers of the code) [10:56:38] you mean describing what we mean by shared_resource? [10:56:45] yeah [10:56:48] I think we need a whole lot of documentation about that [10:56:54] it's a resource that's shared [10:56:59] shared between modules, shared between good friends, etc [10:57:01] duh [10:57:37] between what is what I'm asking if that wasn't clear... [10:59:40] did I just get "duh'd" by Jim? Hey man, don't make me come down there :) [11:00:12] *** Joins: tzawadzki (~tomzawadz@192.55.54.39) [11:01:51] *** Quits: tomzawadzki (tomzawadzk@nat/intel/x-iddczysavjxgffqh) (Remote host closed the connection) [11:52:57] *** Quits: tzawadzki (~tomzawadz@192.55.54.39) (Ping timeout: 240 seconds) [12:01:34] *** Joins: tzawadzki (~tomzawadz@192.55.54.39) [12:18:57] *** Quits: tzawadzki (~tomzawadz@192.55.54.39) (Ping timeout: 248 seconds) [12:23:11] *** Joins: tzawadzki (~tomzawadz@192.55.54.39) [12:31:18] *** Quits: tzawadzki (~tomzawadz@192.55.54.39) (Remote host closed the connection) [12:31:30] *** Joins: tzawadzki (~tomzawadz@134.134.139.83) [12:43:33] *** Quits: tzawadzki (~tomzawadz@134.134.139.83) (Ping timeout: 264 seconds) [12:47:30] *** Joins: tzawadzki (~tomzawadz@134.134.139.83) [13:02:52] *** Quits: tzawadzki (~tomzawadz@134.134.139.83) (Remote host closed the connection) [13:02:59] *** Joins: tzawadzki (~tomzawadz@134.134.139.83) [14:39:51] *** Joins: felipefr (~felipef@ip-64-134-181-41.public.wayport.net) [14:59:45] *** Quits: felipefr (~felipef@ip-64-134-181-41.public.wayport.net) (Quit: Leaving...) [15:30:25] drv: this patch needs another +2 - i re-ran one of the earlier patches in this series and bumped it to the front of the queue - once that's done we can push the first 5 patches [15:33:33] jimharris: which patch? [15:33:42] "this patch" [15:34:02] as jimharris would say, duh [15:34:04] my crystall ball tells me it is https://review.gerrithub.io/#/c/spdk/spdk/+/407769/ [15:34:15] no, wait, that one already has two +2s [15:56:03] doh [15:56:10] i think you figured it out [15:56:41] is the test pool down? [16:02:28] I think sethhowe paused it to investigate why the RocksDB machine had its fans running at 100% all the time [16:04:24] jimharris: yeah. Chip has that machine right now and is replacing the thermal paste on it. It was bugging some of the developers that sit by the test pool. [16:04:37] *** Quits: tzawadzki (~tomzawadz@134.134.139.83) (Remote host closed the connection) [17:08:20] *** Joins: bwalker (bwalker@nat/intel/x-nprjgcxtvwvlogdz) [17:08:20] *** Server sets mode: +cnt [17:08:21] *** Server sets mode: +cnt [17:10:38] *** Joins: cunyinch (~cunyinch@134.134.139.72) [17:11:05] *** Joins: pwodkowx (pwodkowx@nat/intel/x-gtmexxmzuiehqjio) [17:12:05] *** Joins: gangcao (~gangcao@134.134.139.72) [17:14:06] *** Joins: changpe1 (~changpe1@134.134.139.72) [17:14:36] *** Joins: kjakimia (kjakimia@nat/intel/x-nustmrwwjqmcpaxu) [17:16:08] *** Joins: pzedlews (~pzedlews@134.134.139.72) [17:17:39] *** Joins: qdai2 (qdai2@nat/intel/x-hxtzxadhlkzbsyap) [17:18:39] *** Joins: peluse (~peluse@134.134.139.72) [17:19:40] *** Joins: ppelplin (ppelplin@nat/intel/x-qilekyhmohevqsei) [17:20:11] *** Joins: tsg (~tsg@134.134.139.72) [17:20:44] *** Joins: vermavis (~vermavis@134.134.139.72) [17:22:12] *** Joins: lgalkax (lgalkax@nat/intel/x-jbjlsnwetbqeskoh) [17:23:12] *** Joins: pniedzwx (pniedzwx@nat/intel/x-khqulgaluyskbaii) [17:24:43] *** Joins: pbshah1 (~pbshah1@134.134.139.72) [17:26:44] *** Joins: ziyeyang (~ziyeyang@134.134.139.72) [17:27:15] *** Joins: jkkariu (~jkkariu@134.134.139.72) [17:27:45] *** Joins: pawelkax (pawelkax@nat/intel/x-xlzwlaipdmcsmuor) [17:28:19] *** Joins: jimharris (~jimharris@134.134.139.72)