[00:00:47] *** Joins: dlw1 (~Thunderbi@114.255.44.141) [00:02:43] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 256 seconds) [00:02:44] *** dlw1 is now known as dlw [00:12:11] *** Quits: darsto (~darsto@89-68-12-100.dynamic.chello.pl) (Ping timeout: 276 seconds) [00:16:42] *** Joins: darsto (~darsto@89-68-12-100.dynamic.chello.pl) [00:17:05] *** darsto is now known as Guest11493 [00:37:49] *** Quits: Guest11493 (~darsto@89-68-12-100.dynamic.chello.pl) (Ping timeout: 248 seconds) [00:42:14] *** Joins: darsto_ (~darsto@89-68-12-100.dynamic.chello.pl) [00:42:37] *** darsto_ is now known as Guest54206 [00:45:08] *** Guest54206 is now known as darsto [00:45:38] *** darsto is now known as Guest53710 [00:50:25] *** Quits: dlw (~Thunderbi@114.255.44.141) (Ping timeout: 248 seconds) [01:06:14] *** Quits: Guest53710 (~darsto@89-68-12-100.dynamic.chello.pl) (Ping timeout: 276 seconds) [01:10:44] *** Joins: darsto- (~darsto@89-68-12-100.dynamic.chello.pl) [01:46:11] *** darsto- is now known as darsto [01:46:41] *** darsto is now known as Guest74589 [02:50:28] *** Joins: dlw (~Thunderbi@114.255.44.143) [03:21:13] *** Joins: tzawadzki (tomzawadzk@nat/intel/x-xoymexjkxxnwzhsy) [03:21:13] *** Quits: tomzawadzki (~tomzawadz@134.134.139.72) (Remote host closed the connection) [03:33:21] *** Quits: tzawadzki (tomzawadzk@nat/intel/x-xoymexjkxxnwzhsy) (Ping timeout: 264 seconds) [03:34:40] *** Joins: tzawadzki (~tomzawadz@134.134.139.72) [03:37:58] *** Quits: dlw (~Thunderbi@114.255.44.143) (Remote host closed the connection) [03:38:13] *** Joins: dlw (~Thunderbi@114.255.44.143) [03:51:13] *** Quits: tzawadzki (~tomzawadz@134.134.139.72) (Ping timeout: 248 seconds) [03:54:40] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 265 seconds) [04:57:16] *** Joins: dlw (~Thunderbi@114.252.46.203) [05:07:50] *** Quits: dlw (~Thunderbi@114.252.46.203) (Ping timeout: 256 seconds) [05:22:43] *** Joins: dlw (~Thunderbi@114.252.46.203) [05:37:33] *** Quits: dlw (~Thunderbi@114.252.46.203) (Ping timeout: 265 seconds) [05:44:24] *** Joins: dlw (~Thunderbi@114.252.46.203) [05:51:09] *** Quits: dlw (~Thunderbi@114.252.46.203) (Ping timeout: 260 seconds) [06:10:40] *** Joins: tomzawadzki (tomzawadzk@nat/intel/x-naxvustnryyqzmvf) [06:31:17] *** Joins: dlw (~Thunderbi@114.252.46.203) [06:45:29] *** Guest74589 is now known as darsto [06:45:29] *** Quits: dlw (~Thunderbi@114.252.46.203) (Ping timeout: 268 seconds) [08:14:47] *** Joins: lhodev (~lhodev@inet-hqmc05-o.oracle.com) [08:15:41] is the build pool up and running now or is there something that needs my attention? [08:15:44] it looks running to me [08:16:18] *** Joins: tkulasek (~tkulasek@192.55.54.45) [08:16:20] supposedly GerritHub can now support the new Gerrit UI fully [08:17:20] the first thing I notice about the new UI is that my custom dashboard doesn't work though [08:19:15] mine seems to work OK [08:19:28] do you have any references to drafts in your dashboard? maybe that is tripping it up now that those are removed [08:19:59] or do you mean it doesn't work with the new UI? [08:26:51] *** Quits: lhodev (~lhodev@inet-hqmc05-o.oracle.com) (Remote host closed the connection) [08:27:21] *** Joins: lhodev (~lhodev@inet-hqmc05-o.oracle.com) [08:28:26] with the new UI [08:28:33] works on old UI [08:29:38] *** Quits: lhodev (~lhodev@inet-hqmc05-o.oracle.com) (Remote host closed the connection) [08:30:21] *** Joins: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) [08:32:44] *** Quits: tomzawadzki (tomzawadzk@nat/intel/x-naxvustnryyqzmvf) (Ping timeout: 260 seconds) [08:46:55] bwalker: there are 2 patches that TP is trying to test repeatedly [08:47:03] "vhost: fixed memory leak" and "rpc: modify module functions to use dict as argument" [08:47:28] they are in queue atm [08:49:10] yeah, klateck just started an email thread about that too [08:49:17] they are in some weird state - I can't open them up in the web UI at all [08:49:41] yeah, noone can - even the owner [08:51:53] bwalker: this fixes a static analysis issue: https://review.gerrithub.io/#/c/spdk/spdk/+/408533/ [08:58:24] *** Quits: tkulasek (~tkulasek@192.55.54.45) (Ping timeout: 255 seconds) [09:00:28] darsto: just FYI, I've pushed your rte_vhost patches (both v18.01.x and master) to GerritHub [09:16:02] bwalker: also, gangcao posted some comments on your update to https://review.gerrithub.io/#/c/spdk/spdk/+/408291/ [09:17:02] ok looking now [09:17:26] this patch needs one more reviewer: https://review.gerrithub.io/#/c/spdk/spdk/+/407356/ [09:17:39] so does this one: https://review.gerrithub.io/#/c/spdk/spdk/+/407230/ [09:19:14] *** Joins: travis-ci (~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com) [09:19:15] (spdk/master) iscsi: close connection array shm file descriptor (Daniel Verkamp) [09:19:15] Diff URL: https://github.com/spdk/spdk/compare/2fa8447f2ffe...e608e8e54d1b [09:19:15] *** Parts: travis-ci (~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com) () [09:20:16] *** Joins: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) [09:20:17] (spdk/master) doc/nvmf: update readme to include nqn definition (Seth Howell) [09:20:17] Diff URL: https://github.com/spdk/spdk/compare/e608e8e54d1b...cb0f48791c58 [09:20:17] *** Parts: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) () [09:20:43] yeah gangcao makes a few good points on that QoS patch. I'll get it cleaned up here shortly [09:45:26] is there any reason our fio plugin README's aren't plumbed into our top level doc page? [09:45:43] i don't think so but wanted to ask before i fix it [09:48:50] no [09:51:38] they aren't part of the Doxyfile currently, but they could be [10:53:03] *** Joins: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) [10:53:04] (spdk/master) bdev: I/O stats are now kept on the io_submit_ch (Ben Walker) [10:53:04] Diff URL: https://github.com/spdk/spdk/compare/cb0f48791c58...41d94136e604 [10:53:04] *** Parts: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) () [11:12:39] darsto: i posted comments on https://review.gerrithub.io/#/c/spdk/spdk/+/408611/ - can you take a look? [11:15:41] jimharris: yep [11:25:14] *** Joins: travis-ci (~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com) [11:25:15] (spdk/master) nvme: change num_children to be wider type (Pawel Wodkowski) [11:25:15] Diff URL: https://github.com/spdk/spdk/compare/41d94136e604...f9fae3f3a9f6 [11:25:15] *** Parts: travis-ci (~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com) () [11:33:45] *** Joins: travis-ci (~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com) [11:33:46] (spdk/master) vhost-nvme: use the new vhost API for memory address translation (Changpeng Liu) [11:33:46] Diff URL: https://github.com/spdk/spdk/compare/f9fae3f3a9f6...8fdc3c04240e [11:33:46] *** Parts: travis-ci (~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com) () [11:36:35] I had a moment of doubt [11:37:02] it's crap, but should work until we come up with a massive refactor [11:37:09] jimharris: replied [12:41:06] darsto: got it - forgot that we stop/start for every queue [12:41:27] agree - it should work but as pwodkowx so eloquently said "my eyes are bleeding" :) [12:53:42] *** Joins: dlw (~Thunderbi@114.252.46.203) [13:09:52] jimharris: can you take a look at https://review.gerrithub.io/#/c/spdk/spdk/+/408709/ [13:11:19] +2 [13:11:52] drv: https://review.gerrithub.io/#/c/spdk/spdk/+/408738/ made no difference on the heading font sizes - can you hit me with the appropriate clue bat? [13:12:01] yeah, was just looking at that [13:12:05] gotta put on my web developer hat [13:12:25] *** Joins: travis-ci (~travis-ci@ec2-54-87-13-40.compute-1.amazonaws.com) [13:12:27] (spdk/master) examples/perf: set the number of IO requests for each queue pair (Changpeng Liu) [13:12:27] Diff URL: https://github.com/spdk/spdk/compare/8fdc3c04240e...23d7be943386 [13:12:27] *** Parts: travis-ci (~travis-ci@ec2-54-87-13-40.compute-1.amazonaws.com) () [13:12:34] looks like there is some other rule somewhere setting font-size: 30px for h2 [13:12:37] maybe from bootstrap [13:12:56] h3 looks the same too though [13:13:04] yeah, I think bootstrap overrides all of them [13:14:45] not sure of the best way to fix this - we could try adding !important to our css rules, but that's kind of a hack [13:16:32] i'm just going to abandon my patch for now [13:17:12] bwalker: are you using the new UI now? [13:17:15] ok, maybe bwalker can provide some more web dev insights [13:19:43] *** Joins: travis-ci (~travis-ci@ec2-54-87-13-40.compute-1.amazonaws.com) [13:19:44] (spdk/master) bdev/aio: Fix EAGAIN handling. (Andrey Kuzmin) [13:19:44] Diff URL: https://github.com/spdk/spdk/compare/2679d88a2592...55eb9617cfe2 [13:19:44] *** Parts: travis-ci (~travis-ci@ec2-54-87-13-40.compute-1.amazonaws.com) () [13:26:28] *** Joins: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) [13:26:29] (spdk/master) vhost_scsi: support initiators without eventq/controlq (Dariusz Stojaczyk) [13:26:29] Diff URL: https://github.com/spdk/spdk/compare/55eb9617cfe2...1d74fea0159e [13:26:29] *** Parts: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) () [13:32:37] jimharris: does the vhost-user virtio protocol feature bit have any compatibility implications for older qemu? https://review.gerrithub.io/#/c/spdk/spdk/+/408416/ [13:33:25] *** Joins: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) [13:33:27] (spdk/master) CHANGELOG.md: document DPDK CVE-2018-1059 fixes (Jim Harris) [13:33:27] Diff URL: https://github.com/spdk/spdk/compare/1d74fea0159e...60622c61f942 [13:33:27] *** Parts: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) () [13:33:54] did we have support for these messages already and just didn't negotiate the feature bit? [13:35:14] correct [13:35:23] these were added for vhost-blk [13:35:51] ok, I'm just a bit confused as to why it mentions qemu 2.12 then [13:35:56] shouldn't it work even if we don't negotiate this bit? [13:36:08] (presumably the get/set config messages would just not be used then) [13:36:26] changpeng didn't have these messages in his original vhost-blk patches [13:36:58] oh, so vhost-user-blk requires F_CONFIG to work at all? [13:37:00] i'm pretty sure qemu 2.12 will refuse to do vhost-blk if the target doesn't support these messages [13:37:10] ok, seems reasonable to me then [13:39:47] I'm going to merge https://review.gerrithub.io/#/c/spdk/spdk/+/408266/ on the assumption that we plan to fix Pawel's concerns on the qemu side [13:44:23] ok [13:59:28] bwalker: can you take a look at ziyeyang's nvmf admin qpair disconnect patch? https://review.gerrithub.io/#/c/spdk/spdk/+/407743/ [14:01:54] *** Joins: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) [14:01:55] (spdk/master) bdev/gpt: fix gpt scan for block sizes > 32KB (Dariusz Stojaczyk) [14:01:55] Diff URL: https://github.com/spdk/spdk/compare/d08a33f5a333...0587e970e5d5 [14:01:55] *** Parts: travis-ci (~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com) () [14:12:00] jimharris: I switched back to the old UI [14:13:26] bwalker, jimharris: please take another pass over the 18.04 patch list - https://review.gerrithub.io/#/q/status:open+project:spdk/spdk+branch:master+topic:18.04 [14:13:34] we should ideally have everything in by the end of the day today [14:54:10] bwalker: i posted some comments/questions on https://review.gerrithub.io/#/c/spdk/spdk/+/408291/ - can you take a look? [14:56:55] yeah looking [14:59:02] yeah I agree. Will get that patch fixed up [15:08:40] hmm, it looks like there's one call to the new spdk_vhost_gpa_to_vva() without a return value check [15:08:44] in vhost_scsi.c process_ctrl_request() [15:15:15] https://review.gerrithub.io/#/c/spdk/spdk/+/408759/ should fix that, I think [15:55:29] *** Quits: dlw (~Thunderbi@114.252.46.203) (Ping timeout: 248 seconds) [16:10:39] thanks bwalker - patch looks good [16:12:02] drv: this iSCSI network namespace tests patch still makes me nervous [16:12:15] do we want to wait until after the release for that? [16:12:24] but i know that without it we can't test VPP in the test pool [16:13:12] the next patch in that series is marked 18.04 but still has RFC in the title [16:13:21] is the test pool ready for VPP tests? [16:13:47] I think sethhowe installed VPP last Thursday, but I don't think we've tested it, since the patch is marked RFC [16:14:02] we should probably un-RFC it and see what happens, at least [16:14:46] bombs away [16:17:59] I think vhost-nvme is currently not checking for a free slot in the CQ before starting processing of an SQE [16:18:13] it looks like if it ever filled the CQ, it would just start overwriting old CQ entries [16:19:51] ok - can you bring it to changpe1's attention? i'm not sure he's reading history here [16:20:13] yes, I'll send an email [16:26:38] *** Joins: travis-ci (~travis-ci@ec2-54-87-13-40.compute-1.amazonaws.com) [16:26:39] (spdk/master) bdev/qos: update the RPC method to make 0 iops mean unlimited (GangCao) [16:26:39] Diff URL: https://github.com/spdk/spdk/compare/0587e970e5d5...9c7d842cc429 [16:26:39] *** Parts: travis-ci (~travis-ci@ec2-54-87-13-40.compute-1.amazonaws.com) () [16:31:01] bwalker: can you take a quick look at https://review.gerrithub.io/#/c/spdk/spdk/+/408743/ [16:42:57] jimharris: looks like the VPP test patch still needs some work [18:10:24] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [18:17:16] drv: Young Tack's pci-whitelist/black list patch is improving. I would like to hear your thought. Do we have to copy the pci-whitelist/blacklist itself from app_opts to env_opts, or coping just the pointer is enough? [18:17:35] https://review.gerrithub.io/#/c/spdk/spdk/+/405911/ [18:28:47] *** Joins: dlw (~Thunderbi@114.255.44.143) [18:35:01] drv: this patch is not urgent for the next release. I'll post a question to Gerrit and then you'll able to check that. [18:59:11] @drv @bwalker, can you review this patch again and see my comments: https://review.gerrithub.io/#/c/spdk/spdk/+/407743/ [20:41:44] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [21:01:47] @Shuhei, Can you review https://review.gerrithub.io/#/c/spdk/spdk/+/394700/ and https://review.gerrithub.io/#/c/spdk/spdk/+/394699/ [21:01:51] again? Thanks [23:47:11] *** Joins: tomzawadzki (tomzawadzk@nat/intel/x-ivjndhpnoykxyuou)