[00:04:53] *** Joins: dlw1 (~Thunderbi@114.255.44.143) [00:06:56] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 276 seconds) [00:06:56] *** dlw1 is now known as dlw [00:43:14] *** Quits: sage___ (~quassel@2607:f298:5:101d:f816:3eff:fe21:1966) (Ping timeout: 276 seconds) [00:46:13] *** Joins: tomzawadzki (tomzawadzk@nat/intel/x-kfvjdohqxwdpavmm) [01:22:40] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [02:32:53] *** Joins: sage___ (~quassel@2607:f298:5:101d:f816:3eff:fe21:1966) [04:01:08] *** Quits: tomzawadzki (tomzawadzk@nat/intel/x-kfvjdohqxwdpavmm) (Remote host closed the connection) [04:01:18] *** Joins: tomzawadzki (tomzawadzk@nat/intel/x-yamaclonmwmjaxxa) [04:16:34] *** Quits: dlw (~Thunderbi@114.255.44.143) (Read error: Connection reset by peer) [04:20:38] *** Joins: dlw (~Thunderbi@114.255.44.143) [04:46:13] *** Quits: dlw (~Thunderbi@114.255.44.143) (Quit: dlw) [05:05:25] *** Joins: alessio (~alessio@140.105.207.235) [05:20:05] *** Quits: windyon (67412840@gateway/web/freenode/ip.103.65.40.64) (Ping timeout: 260 seconds) [06:07:55] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Quit: Leaving.) [06:09:16] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [06:14:05] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 240 seconds) [07:23:29] *** Joins: dlw (~Thunderbi@111.197.238.166) [07:24:40] *** Joins: lhodev (~Adium@inet-hqmc03-o.oracle.com) [08:20:45] *** Joins: tkulasek (tkulasek@nat/intel/x-eylaroadgfhcigye) [08:57:51] *** Quits: tomzawadzki (tomzawadzk@nat/intel/x-yamaclonmwmjaxxa) (Ping timeout: 240 seconds) [09:15:02] *** Quits: dlw (~Thunderbi@111.197.238.166) (Remote host closed the connection) [09:16:41] jimharris: have you seen this RocksDB failure in the nightly test run? https://ci.spdk.io/spdk/builds/review/b005c890dd5b1d322803fc22d3108815c3f4df4d.1522066614/fedora-04/rocksdb/writesync_db_bench.txt [09:17:05] the crash is on the first statement in spdk_file_read(), pthread_spin_lock(&file->lock); [09:17:10] so I assume file is NULL at that point [09:18:47] not sure how that can happen; I assume the SpdkRandomAccessFile constructor should throw an exception if it fails to open [09:19:51] although now that I say that, I don't see anything in env_spdk.cc that actually checks it [09:22:56] in the rocksdb env_posix implementation, they check for that in NewRandomAccessFile() [09:24:57] *** Quits: tkulasek (tkulasek@nat/intel/x-eylaroadgfhcigye) (Ping timeout: 264 seconds) [09:39:03] wow, this rocksdb env code is missing checks for a lot of function return values [10:17:32] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [10:18:50] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Client Quit) [10:48:57] *** Joins: param (~param@157.49.153.204) [10:50:04] drv : I have added comment to the card.. https://trello.com/c/ihJs1gXy/26-to-check-if-a-new-in-coming-connection-is-from-allowed-listener-list.. [11:45:57] *** Quits: param (~param@157.49.153.204) (Remote host closed the connection) [12:09:51] *** Joins: erodriguez (d8f01e0b@gateway/web/freenode/ip.216.240.30.11) [12:10:42] Is there something more I need to do for https://review.gerrithub.io/#/c/401957/ ? [13:00:27] *** Quits: lhodev (~Adium@inet-hqmc03-o.oracle.com) (Remote host closed the connection) [13:02:03] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) [13:19:40] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [13:24:23] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 276 seconds) [13:47:32] erodriguez: it's just waiting for a second +2 from a maintainer [13:48:08] jimharris is currently traveling, so it might be a little while [14:23:21] *** Quits: guerby (~guerby@april/board/guerby) (Ping timeout: 240 seconds) [15:10:55] *** Joins: guerby (~guerby@april/board/guerby) [15:20:19] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [15:24:57] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 264 seconds) [17:20:32] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [17:24:27] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 240 seconds) [17:43:13] hi erodriguez - there are a few places where the logic could be simplified - otherwise that patch looks great [17:56:26] *** Joins: dlw (~Thunderbi@114.255.44.143) [19:20:45] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [19:25:33] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 264 seconds) [19:36:15] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [19:40:33] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 248 seconds) [21:38:53] *** Joins: wenyu (67412840@gateway/web/freenode/ip.103.65.40.64) [21:49:41] *** Joins: travis-ci (~travis-ci@ec2-54-205-141-74.compute-1.amazonaws.com) [21:49:41] (spdk/master) test: move lib/ioat up one directory (Seth Howell) [21:49:42] Diff URL: https://github.com/spdk/spdk/compare/b1bdc370cafb...0bc7c3de4b13 [21:49:42] *** Parts: travis-ci (~travis-ci@ec2-54-205-141-74.compute-1.amazonaws.com) () [21:52:13] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [21:56:47] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Ping timeout: 268 seconds) [22:01:14] *** Joins: travis-ci (~travis-ci@ec2-54-224-29-22.compute-1.amazonaws.com) [22:01:15] (spdk/master) bdev/virtio: ensure thread safety for adding/removing devices (Dariusz Stojaczyk) [22:01:15] Diff URL: https://github.com/spdk/spdk/compare/0bc7c3de4b13...46bce34c2483 [22:01:15] *** Parts: travis-ci (~travis-ci@ec2-54-224-29-22.compute-1.amazonaws.com) () [22:02:27] *** Joins: travis-ci (~travis-ci@ec2-54-205-141-74.compute-1.amazonaws.com) [22:02:28] (spdk/master) pep8: fix E305 (2 blank lines after functions) (Dariusz Stojaczyk) [22:02:28] Diff URL: https://github.com/spdk/spdk/compare/46bce34c2483...4f5bf64af125 [22:02:28] *** Parts: travis-ci (~travis-ci@ec2-54-205-141-74.compute-1.amazonaws.com) () [23:47:59] *** Joins: travis-ci (~travis-ci@ec2-54-205-141-74.compute-1.amazonaws.com) [23:48:01] (spdk/master) bdev/nvme: provide namespace UUID to bdev layer (Daniel Verkamp) [23:48:01] Diff URL: https://github.com/spdk/spdk/compare/4f5bf64af125...8f1c45b1b7e0 [23:48:01] *** Parts: travis-ci (~travis-ci@ec2-54-205-141-74.compute-1.amazonaws.com) () [23:59:58] *** Joins: travis-ci (~travis-ci@ec2-54-163-184-30.compute-1.amazonaws.com)