[00:06:31] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [00:14:09] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 248 seconds) [00:20:53] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [00:37:19] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 260 seconds) [00:42:36] *** Joins: tomzawadzki (~tomzawadz@134.134.139.75) [00:43:06] *** Joins: tzawadzki (~tomzawadz@192.55.54.45) [00:43:07] *** Quits: tomzawadzki (~tomzawadz@134.134.139.75) (Remote host closed the connection) [00:47:39] *** Quits: tzawadzki (~tomzawadz@192.55.54.45) (Client Quit) [00:47:52] *** Joins: tzawadzki (tomzawadzk@nat/intel/x-ajxegnnnfixzomel) [01:06:44] *** Joins: tkulasek (~tkulasek@134.134.139.76) [01:13:54] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [01:33:18] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [01:43:32] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 245 seconds) [02:06:23] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [02:25:25] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 256 seconds) [02:46:38] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [02:54:09] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 248 seconds) [03:47:37] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [04:11:50] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 256 seconds) [04:28:34] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [04:35:12] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 268 seconds) [04:50:57] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [06:02:17] *** Guest70287 is now known as darsto [06:13:13] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 240 seconds) [06:50:52] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [07:03:39] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 256 seconds) [07:41:30] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [07:47:17] is someone taking care of https://github.com/spdk/spdk/issues/261 ? [07:59:06] The % of failures on TP (and jenkins) is getting into rly high :( [08:21:46] *** Parts: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) () [08:21:51] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) [08:35:21] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Read error: Connection reset by peer) [08:37:54] *** Joins: param (~param@106.51.65.217) [08:40:29] drv : jim : looks like some error in SPDK automated system.. https://review.gerrithub.io/#/c/404012/ ..when i look for logs its saying Object not found. [08:43:37] *** Joins: travis-ci (~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com) [08:43:37] (spdk/master) doc: Programmer's guide template and example for blobstore (Paul Luse) [08:43:38] Diff URL: https://github.com/spdk/spdk/compare/315630a2fd15...da58800f21a3 [08:43:38] *** Parts: travis-ci (~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com) () [08:44:14] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [08:54:50] param: thanks for pointing that out. It looks like there is an error in the build pool when two revisions to a commit are pushed before the commit runs in the build pool. Your change is located here: https://ci.spdk.io/spdk/builds/review/c70c6805d72bbf8c6365ecd0ecb3ac431777074f.1521234268/ [08:57:20] param: I will take a closer look at why the review was posted under the second commit instead of the third one and get a fix into the build pool to post accurate links. [08:58:14] sethhowe : thanks... [08:58:37] drv : jim : https://ci.spdk.io/spdk/builds/review/c70c6805d72bbf8c6365ecd0ecb3ac431777074f.1521234268/fedora-06/build.log [08:59:21] is this a known crash dump? [09:01:52] sethhowe : is that the reason for crash? [09:02:32] *** Parts: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) () [09:04:07] param: The incorrect label in gerrit is not the reason for the crash. I believe this is a known issue with NVMe-oF [09:05:05] oh..okay.. [09:07:26] param: I have re-queued your patch. [09:09:24] sethhowe : thanks... [09:14:52] *** Joins: boutcher (~boutcher@66.113.132.66) [09:33:37] *** Quits: tzawadzki (tomzawadzk@nat/intel/x-ajxegnnnfixzomel) (Ping timeout: 248 seconds) [09:41:45] *** Quits: tkulasek (~tkulasek@134.134.139.76) (Ping timeout: 264 seconds) [09:46:37] *** Quits: param (~param@106.51.65.217) (Quit: Going offline, see ya! (www.adiirc.com)) [10:10:57] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 240 seconds) [10:21:02] *** Joins: param (~param@157.49.32.222) [10:21:35] jim : drv : can i add patch to check for the listen address list during login time? [10:22:22] *** Quits: param (~param@157.49.32.222) (Client Quit) [10:22:47] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [10:23:05] *** Joins: param (~param@157.49.109.254) [10:35:11] *** Quits: param (~param@157.49.109.254) (Quit: Going offline, see ya! (www.adiirc.com)) [10:35:50] *** Joins: param (~param@157.49.32.222) [10:46:36] *** Joins: travis-ci (~travis-ci@ec2-54-166-88-144.compute-1.amazonaws.com) [10:46:37] (spdk/master) bdev: consolidate I/O completion message passing (Daniel Verkamp) [10:46:37] Diff URL: https://github.com/spdk/spdk/compare/da58800f21a3...0d7d3a05c34b [10:46:37] *** Parts: travis-ci (~travis-ci@ec2-54-166-88-144.compute-1.amazonaws.com) () [10:55:36] *** Quits: param (~param@157.49.32.222) (Quit: Going offline, see ya! (www.adiirc.com)) [10:56:15] *** Joins: param (~param@157.49.32.222) [11:16:10] *** Quits: param (~param@157.49.32.222) (Quit: Going offline, see ya! (www.adiirc.com)) [11:16:49] *** Joins: param (~param@157.49.109.254) [11:36:43] *** Quits: param (~param@157.49.109.254) (Quit: Going offline, see ya! (www.adiirc.com)) [11:37:22] *** Joins: param (~param@157.49.109.254) [11:50:35] drv: https://review.gerrithub.io/#/c/404410/ - this should fix at least one of the intermittent failures with the nvmf tests [12:03:57] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 240 seconds) [12:05:44] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [12:06:32] *** Quits: param (~param@157.49.109.254) (Quit: Going offline, see ya! (www.adiirc.com)) [12:07:12] *** Joins: param (~param@157.49.32.222) [12:24:29] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 268 seconds) [12:26:50] *** Quits: param (~param@157.49.32.222) (Quit: Going offline, see ya! (www.adiirc.com)) [12:27:33] *** Joins: param (~param@157.49.109.254) [12:35:13] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [12:37:59] *** Joins: tkulasek (~tkulasek@192.55.54.40) [12:42:31] *** Quits: tkulasek (~tkulasek@192.55.54.40) (Ping timeout: 256 seconds) [12:43:05] *** Quits: param (~param@157.49.109.254) (Quit: Going offline, see ya! (www.adiirc.com)) [12:59:41] *** Joins: travis-ci (~travis-ci@ec2-54-81-208-176.compute-1.amazonaws.com) [12:59:41] (spdk/master) iscsi: update the spdk_iscsi_poll_group_poll handling (GangCao) [12:59:42] Diff URL: https://github.com/spdk/spdk/compare/0d7d3a05c34b...7954a8dc2abf [12:59:42] *** Parts: travis-ci (~travis-ci@ec2-54-81-208-176.compute-1.amazonaws.com) () [13:03:54] *** Quits: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) (Ping timeout: 246 seconds) [13:19:25] *** Joins: travis-ci (~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com) [13:19:26] (spdk/master) test/lvol: fix the range of test cases when use "all" parameter (Chen Wang) [13:19:26] Diff URL: https://github.com/spdk/spdk/compare/74af349ddbe1...a81dd12daf0b [13:19:26] *** Parts: travis-ci (~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com) () [13:21:18] *** Joins: mphardy (~mphardy@pool-72-83-7-2.washdc.fios.verizon.net) [13:27:31] *** Joins: travis-ci (~travis-ci@ec2-54-166-88-144.compute-1.amazonaws.com) [13:27:32] (spdk/master) NVMf : RPC to remove listener (param) [13:27:32] Diff URL: https://github.com/spdk/spdk/compare/a81dd12daf0b...a1ee11876989 [13:27:32] *** Parts: travis-ci (~travis-ci@ec2-54-166-88-144.compute-1.amazonaws.com) () [13:29:53] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) [13:30:44] *** Parts: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) () [13:30:49] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) [13:44:58] jimharris: looks like your second io_channel patch blew up in the pmem unit tests [13:47:52] ack [14:00:41] *** Joins: jkkariu (jkkariu@nat/intel/x-rxqhqihzohohnndh) [14:31:30] *** Joins: travis-ci (~travis-ci@ec2-54-166-88-144.compute-1.amazonaws.com) [14:31:31] (spdk/master) bdev: count per-bdev outstanding I/O (Dariusz Stojaczyk) [14:31:31] Diff URL: https://github.com/spdk/spdk/compare/a1ee11876989...09fb50530eef [14:31:31] *** Parts: travis-ci (~travis-ci@ec2-54-166-88-144.compute-1.amazonaws.com) () [15:42:04] what was us with the travis-ci posts? [15:42:14] us=up [15:47:58] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [15:52:15] do we have MIN and MAX macros defined somewhere in SPDK and if not where's the best place to add them? [15:54:20] spdk_min and spdk_max in util.h [15:54:43] we turned on IRC notifications from Travis so we can see when stuff was merged into master [15:57:58] cool, thanks [15:58:08] I like the notifications BTW [16:00:07] Hi All, "int rc; rc = func(); if (rc !=0) { handle error; }" ... looks more usual than "if (func() != 0) { handle error; }" in DPDK and SPDK. The former is implicit coding rule or recommendation in SPDK? [16:01:29] I understand adding curly braces everywhere is the official coding rule in SPDK. [16:02:21] I haven't asked this question before and any feedback is helpful for me. Thanks. [16:03:05] Shuhei, are you asking if that first pattern you mention is what you should be doing? [16:03:26] if so, yes :) [16:03:41] I would say it depends on whether you need to use the value of rc later [16:03:57] personally, I'd generally use the second form unless you actually need to do something with rc (like return it to the next level up) [16:04:06] but either one is okay [16:04:38] drv, when you get a chance... https://review.gerrithub.io/#/c/399768/13..16 is ready. Would like to merge so John can work off master for the lab instead of a moving target [16:04:51] ok, I'll put it on the pile :) [16:05:00] well, I think its ready anyways ;) [16:05:18] gracias [16:06:07] Hi Daniel, thank you for your feedback. It's valuable for me to review or write the code. [16:06:41] Hi Paul, [16:08:36] I feel I look often the first patten in SPDK and DPDK. I wanted to know or confirm what is the criteria to choose either one in SPDK, because I would like to follow SPDK's way both for review and writing. [16:09:03] Daniel's feedback was almost what I wanted to know. [16:09:10] Thank you, Paul. [18:01:19] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [18:11:25] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [18:43:54] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [18:53:25] *** Joins: travis-ci (~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com) [18:53:26] (spdk/master) io_channel: invoke unregister_cb on same thread unregister was called (Jim Harris) [18:53:26] Diff URL: https://github.com/spdk/spdk/compare/09fb50530eef...a8d3ac0cf4b8 [18:53:26] *** Parts: travis-ci (~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com) () [20:18:04] *** Joins: param (~param@157.49.131.202) [20:24:08] *** Joins: param_ (~param@106.206.66.229) [20:27:45] *** Quits: param (~param@157.49.131.202) (Ping timeout: 256 seconds) [20:27:49] *** param_ is now known as param [20:34:47] *** Joins: dwv00tt (~eufpzf@47.198.83.19) [20:34:48] *** Quits: dwv00tt (~eufpzf@47.198.83.19) (Client Quit) [20:38:22] *** Quits: param (~param@106.206.66.229) (Quit: Going offline, see ya! (www.adiirc.com)) [20:39:16] *** Joins: param (~param@106.206.66.229) [20:57:09] *** Joins: ziyeyang_ (~ziyeyang@192.55.54.44) [21:07:47] *** Quits: ziyeyang_ (~ziyeyang@192.55.54.44) (Quit: Leaving) [21:08:52] *** Quits: param (~param@106.206.66.229) (Quit: Going offline, see ya! (www.adiirc.com)) [21:09:49] *** Joins: param (~param@106.206.66.229) [21:39:25] *** Quits: param (~param@106.206.66.229) (Quit: Going offline, see ya! (www.adiirc.com)) [21:40:22] *** Joins: param (~param@106.206.66.229) [22:09:59] *** Quits: param (~param@106.206.66.229) (Quit: Going offline, see ya! (www.adiirc.com)) [22:10:39] *** Joins: param (~param@106.206.66.229) [22:40:32] *** Quits: param (~param@106.206.66.229) (Quit: Going offline, see ya! (www.adiirc.com)) [22:41:29] *** Joins: param (~param@106.206.66.229) [23:18:35] *** Quits: param (~param@106.206.66.229) (Read error: Connection reset by peer) [23:37:40] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97)