[00:11:33] *** Quits: param (~param@106.51.65.217) (Quit: Going offline, see ya! (www.adiirc.com)) [00:34:17] *** Joins: ziyeyang__ (ziyeyang@nat/intel/x-rfvpifoaidudymbx) [00:34:18] *** Quits: ziyeyang_ (~ziyeyang@192.55.54.45) (Remote host closed the connection) [00:50:07] *** Joins: tomzawadzki (~tomzawadz@134.134.139.83) [00:57:19] *** Joins: param (~param@106.51.65.217) [01:08:00] *** Quits: ziyeyang__ (ziyeyang@nat/intel/x-rfvpifoaidudymbx) (Quit: Leaving) [01:23:39] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [02:22:58] *** Quits: tomzawadzki (~tomzawadz@134.134.139.83) (Quit: Leaving) [02:23:08] *** Joins: tomzawadzki (~tomzawadz@134.134.139.83) [02:23:40] *** Joins: tkulasek (~tkulasek@134.134.139.75) [02:46:25] *** Quits: param (~param@106.51.65.217) (Quit: Going offline, see ya! (www.adiirc.com)) [03:32:38] *** Joins: param (~param@106.51.65.217) [04:37:34] *** Joins: pzedlews_ (uid285827@gateway/web/irccloud.com/x-wtipgjjzcnkropyu) [05:14:50] *** Joins: tatpapvv (~bnwcvo@162.223.10.10) [05:14:51] *** Quits: tatpapvv (~bnwcvo@162.223.10.10) (Client Quit) [05:19:12] *** Quits: tkulasek (~tkulasek@134.134.139.75) (Remote host closed the connection) [05:19:23] *** Joins: tkulasek (tkulasek@nat/intel/x-gpdqbuuwejuvaymk) [05:34:01] *** Quits: param (~param@106.51.65.217) (Quit: Going offline, see ya! (www.adiirc.com)) [06:07:23] *** Joins: johnmeneghini (~johnmeneg@216.240.30.5) [07:57:51] *** Parts: lhodev (~Adium@66.90.218.190) () [07:57:55] *** Joins: lhodev (~Adium@66.90.218.190) [08:03:33] *** Parts: lhodev (~Adium@66.90.218.190) () [08:05:08] *** Joins: erodriguez (d8f01e19@gateway/web/freenode/ip.216.240.30.25) [08:23:49] Could somebody take a look at his build failure and let me know if you think its legit: https://ci.spdk.io/spdk/builds/review/e529500fa012aafad3e18494bd31c5e08b95c657.1521090041/ [08:26:51] *** Quits: pzedlews_ (uid285827@gateway/web/irccloud.com/x-wtipgjjzcnkropyu) (Quit: Connection closed for inactivity) [08:49:57] *** Quits: tomzawadzki (~tomzawadz@134.134.139.83) (Ping timeout: 240 seconds) [08:56:07] *** Joins: param (~param@157.49.45.92) [09:29:00] I was wondering how outrun.sh is meant to be used. When I run it, autobuild fails at the 'git status --porcelain' step because the scripts are generating files like timing.txt that are not in .gitignore [09:30:19] I'v tried running from a different dir, i.e. 'cd ~/tmp/build;~/SPDK/master/autorun.sh' without success [09:41:29] erodriguez: that second method is the way it's intended to be used - the output of the build is put in the current directory when you start the script, which should not be the SPDK directory [09:41:35] what is going wrong when you run it that way? [09:43:18] *** Quits: tkulasek (tkulasek@nat/intel/x-gpdqbuuwejuvaymk) (Ping timeout: 246 seconds) [09:47:40] *** Joins: pzedlews_ (uid285827@gateway/web/irccloud.com/x-qixogellhltqiyrl) [09:48:53] I began with git status --porcelain being empty [09:49:43] Then I run this from ~: TIMESTAMP=`date +"%Y%m%d%H%M%S"` && mkdir -pv ~/tmp/build-$TIMESTAMP && pushd ~/tmp/build-$TIMESTAMP; ~/p4/SPDK/master/spdk/autorun.sh ; popd [09:50:02] Which fails: [09:50:02] Generated files missing from .gitignore [09:50:08] 12:45:54 $ git status --porcelain [09:50:14] ?? test_completions.txt [09:50:19] ?? timing.txt [09:50:25] 12:45:54 $ exit 1 [09:51:30] hmm, those should be generated in the output directory ($PWD when you start autorun.sh) - are they actually ending up in ~/p4/SPDK/master/spdk ? [09:52:29] oh, I think the trick is that the output directory has to actually be named 'output'... this really needs to be documented better [09:54:25] output_dir is determined in test/common/autotest_common.sh - looks like the assumption is that there is a directory one level up from the source dir called output [09:56:53] So the spdk repo and 'output' are sibling folders? [09:57:42] right [09:58:03] that's how it works currently, anyway; we should definitely clean this up [09:58:16] alternatively, you can set output_dir in the environment before you call autorun.sh and it won't try to do this autodetection stuff [10:02:41] Thanks, I'll go with setting output_dir when calling autorun.sh [10:12:08] drv : jim : The code can be reviewed.. https://review.gerrithub.io/#/c/404012/ I have added the rpc changes to remove listener in rpc scripts (rpc.py and nvmf.py) .. Once the checking is added for listen address in the code the changes in test can be made.. [10:12:25] Should that change be made as part of this card? [10:28:06] It looks like now there are 2 timing.txt files. One is in $output_dir and the other is in the spdk root - it appears to be from autotest.sh [10:55:46] Do these tests run on systems with Mellanox RDMA adapters? [10:55:47] In test/iscsi_tgt/nvme_remote/fio_remote_nvme.sh [10:55:59] 13:27:09 # python /u/edwinr/p4/SPDK/master/spdk/scripts/rpc.py -s /var/tmp/spdk-iscsi.sock construct_nvme_bdev -b Nvme0 -t rdma -f ipv4 -a 10.63.0.17 -s 4420 -n nqn.2016-06.io.spdk:cnode1 [10:56:06] nvme_rdma.c: 211:nvme_rdma_get_event: *ERROR*: Received event: 7(RDMA_CM_EVENT_UNREACHABLE) from CM event channel, but expected event: (RDMA_CM_EVENT_ESTABLISHED) [10:56:42] maybe because it sets the listen add to 127.0.0.1 [10:56:43] 13:27:09 # python /u/edwinr/p4/SPDK/master/spdk/scripts/rpc.py -s /var/tmp/spdk-iscsi.sock add_portal_group 1 127.0.0.1:3260 [10:56:48] 13:27:09 # python /u/edwinr/p4/SPDK/master/spdk/scripts/rpc.py -s /var/tmp/spdk-iscsi.sock add_initiator_group 1 ANY 127.0.0.1/32 [10:57:38] those are the iSCSI listen addresses - the NVme-oF one should be set up in a previous step [10:57:50] we do run the tests on Mellanox adapters in the test pool [11:03:11] drv: what's up with these failures? [11:03:18] Generated files missing from .gitignore: [11:03:18] 12:30:38 $ git status --porcelain [11:03:18] ?? examples/ioat/kperf/kmod/.cache.mk [11:03:52] we updated the kernel-devel package on the test VMs, and now the ioat kperf test module leaves junk around [11:03:56] it's fixed on master - just rebase [11:04:18] sethhowe sent a note about it yesterday [11:18:07] *** Quits: param (~param@157.49.45.92) (Quit: Going offline, see ya! (www.adiirc.com)) [11:23:18] *** Joins: param (~param@157.49.45.92) [11:25:44] *** Joins: lhodev (~Adium@inet-hqmc06-o.oracle.com) [11:30:15] *** Quits: peluse (~peluse@2600:8800:1407:cb00:ecc2:685c:a7d1:5180) (Ping timeout: 252 seconds) [11:30:15] *** peluse- is now known as peluse [11:57:13] *** Quits: pzedlews_ (uid285827@gateway/web/irccloud.com/x-qixogellhltqiyrl) (Quit: Connection closed for inactivity) [12:07:02] *** Quits: param (~param@157.49.45.92) (Quit: Going offline, see ya! (www.adiirc.com)) [12:45:51] *** Parts: erodriguez (d8f01e19@gateway/web/freenode/ip.216.240.30.25) () [13:25:48] jimharris: ping on this series: https://review.gerrithub.io/#/c/403739/ [13:26:14] this reduces the build size considerably, since we have something like 6 copies of the ut_coverage currently [13:26:25] (and the ci.spdk.io hosting folks have been nagging us about taking too much space) [13:28:34] done [14:20:44] *** Joins: param (~param@157.49.118.96) [14:29:13] drv: can you look at this patch from shuhei? https://review.gerrithub.io/#/c/403913/ [14:29:45] sure, I'll check it out [14:48:28] *** Quits: johnmeneghini (~johnmeneg@216.240.30.5) (Quit: Leaving.) [14:50:47] *** Quits: param (~param@157.49.118.96) (Quit: Going offline, see ya! (www.adiirc.com)) [14:51:23] *** Joins: param (~param@157.49.118.96) [14:55:05] can i push this one now? please????? https://review.gerrithub.io/#/c/403737/ [14:56:20] go for it [14:56:36] we'll see if I got the syntax right :) [14:58:05] pushed [14:58:12] how long does the travis build take? [15:00:17] *** Joins: travis-ci (~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com) [15:00:18] spdk/master: travis: enable IRC notifications (Daniel Verkamp) [15:00:18] *** Parts: travis-ci (~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com) () [15:00:54] thank you travis-ci! [15:01:25] it's usually pretty quick (as you can see) [15:02:05] maybe add %{compare_url}? [15:02:42] sure, we can add whatever you think is helpful - I just grabbed the variables that looked interesting at first glance [15:04:16] I guess we could also add the travis result, although it only runs the unit tests currently [15:05:59] I didn't want it to confuse people if the Travis build passed but our CI tests failed [15:07:24] *** Quits: ziyeyang (ziyeyang@nat/intel/x-dlowcgapndpnsrhh) (*.net *.split) [15:07:24] *** Quits: tsg (tsg@nat/intel/x-ucyptrsclhaaxpcs) (*.net *.split) [15:07:24] *** Quits: ppelplin (ppelplin@nat/intel/x-wsayzzxelbwubfly) (*.net *.split) [15:07:24] *** Quits: pniedzwx (pniedzwx@nat/intel/x-ftrjryvtgwelemzx) (*.net *.split) [15:07:24] *** Quits: peluse (peluse@nat/intel/x-syzxuajntvkflyws) (*.net *.split) [15:07:24] *** Quits: lgalkax (lgalkax@nat/intel/x-fquetuzgjcyoiwdy) (*.net *.split) [15:07:24] *** Quits: klateck (klateck@nat/intel/x-jfmlvhoswjngeqad) (*.net *.split) [15:07:31] *** Quits: darsto_ (~dstojacx@89-68-135-211.dynamic.chello.pl) (*.net *.split) [15:08:00] *** Joins: ziyeyang (ziyeyang@nat/intel/x-dlowcgapndpnsrhh) [15:08:00] *** Joins: tsg (tsg@nat/intel/x-ucyptrsclhaaxpcs) [15:08:00] *** Joins: ppelplin (ppelplin@nat/intel/x-wsayzzxelbwubfly) [15:08:00] *** Joins: pniedzwx (pniedzwx@nat/intel/x-ftrjryvtgwelemzx) [15:08:00] *** Joins: peluse (peluse@nat/intel/x-syzxuajntvkflyws) [15:08:00] *** Joins: lgalkax (lgalkax@nat/intel/x-fquetuzgjcyoiwdy) [15:08:00] *** Joins: klateck (klateck@nat/intel/x-jfmlvhoswjngeqad) [15:08:00] *** Joins: darsto_ (~dstojacx@89-68-135-211.dynamic.chello.pl) [15:21:13] i think we can skip the results - if i'm reading it right, compare_url should give a link to the git commit on github [15:23:20] *** Quits: param (~param@157.49.118.96) (Quit: Going offline, see ya! (www.adiirc.com)) [15:23:54] *** Joins: param (~param@157.49.34.20) [15:25:25] *** Joins: travis-ci (~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com) [15:25:26] spdk/master: bdev/error: move config scanning to vbdev_error_init (Shuhei Matsumoto) [15:25:26] *** Parts: travis-ci (~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com) () [15:29:08] jimharris: I posted some comments on the iSCSI initiator patch - does your +2 mean you want to merge this as is and fix it up later, or should I -1 it as usual? [15:29:22] let me look [15:29:42] https://review.gerrithub.io/#/c/404209/ (travis irc tweaks) [15:30:53] lgtm - go ahead and push when it's done [15:35:45] *** Joins: pzedlews_ (uid285827@gateway/web/irccloud.com/x-eerrvzkizofmmawm) [15:38:25] i responded to all of your comments and changed my vote to -1 - these should all be pretty easy changes - I'll ask Ziye to whip up one more rev and then we can get this in [15:41:32] ok, cool [15:41:44] I'm fine with deferring some of the todo items you wrote down in the readme, but I think these are all doable in short order [15:45:42] *** Quits: lhodev (~Adium@inet-hqmc06-o.oracle.com) (Remote host closed the connection) [15:47:17] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) [15:54:19] so travis-ci doesn't necessarily run on every commit? [15:54:23] *** Quits: param (~param@157.49.34.20) (Quit: Going offline, see ya! (www.adiirc.com)) [15:54:56] i pushed two of Shuhei's changes after your travis notification patch went in - I only saw an IRC notification on the second patch [15:54:58] *** Joins: param (~param@157.49.118.96) [15:55:04] *** Joins: travis-ci (~travis-ci@ec2-54-205-233-71.compute-1.amazonaws.com) [15:55:05] (spdk/master) .travis.yml: tweak IRC notification (Jim Harris) [15:55:05] Diff URL: https://github.com/spdk/spdk/compare/db828b10b41e...315630a2fd15 [15:55:05] *** Parts: travis-ci (~travis-ci@ec2-54-205-233-71.compute-1.amazonaws.com) () [15:58:33] yeah, it looks like Travis skips builds if you push multiple commits at once [15:58:43] it just builds the final one in the series [15:59:07] you can see the green checkmark by the commits that it ran: https://github.com/spdk/spdk/commits/master [16:01:51] currently we have auto-cancel enabled on our spdk project in travis [16:02:18] Auto Cancellation allows you to only run builds for the latest commits in the queue. This setting can be applied to builds for Branch builds and Pull Request builds separately. Builds will only be canceled if they are waiting to run, allowing for any running jobs to finish. [16:02:32] you ok if i try turning that off? [16:02:34] sure [16:02:42] is it on by default? I don't remember setting that anywhere [16:02:48] probably [16:29:00] jimharris: this one could use another look: https://review.gerrithub.io/#/c/400894/ (setting NVMe-oF namespace uuid from bdev uuid) [17:10:26] *** Quits: param (~param@157.49.118.96) (Quit: Going offline, see ya! (www.adiirc.com)) [17:11:00] *** Joins: param (~param@157.49.14.69) [17:47:13] *** Quits: pzedlews_ (uid285827@gateway/web/irccloud.com/x-eerrvzkizofmmawm) (Quit: Connection closed for inactivity) [18:03:30] *** Quits: param (~param@157.49.14.69) (Quit: Going offline, see ya! (www.adiirc.com)) [18:04:04] *** Joins: param (~param@157.49.111.185) [18:34:04] *** Quits: param (~param@157.49.111.185) (Quit: Going offline, see ya! (www.adiirc.com)) [18:34:42] *** Joins: param (~param@157.49.111.185) [19:17:08] *** Quits: param (~param@157.49.111.185) (Quit: Going offline, see ya! (www.adiirc.com)) [19:17:44] *** Joins: param (~param@157.49.111.185) [19:47:41] *** Quits: param (~param@157.49.111.185) (Quit: Going offline, see ya! (www.adiirc.com)) [19:48:17] *** Joins: param (~param@157.49.28.231) [20:18:15] *** Quits: param (~param@157.49.28.231) (Quit: Going offline, see ya! (www.adiirc.com)) [20:18:49] *** Joins: param (~param@157.49.111.185) [20:48:48] *** Quits: param (~param@157.49.111.185) (Quit: Going offline, see ya! (www.adiirc.com)) [20:49:25] *** Joins: param (~param@157.49.28.231) [21:20:22] *** Quits: param (~param@157.49.28.231) (Quit: Going offline, see ya! (www.adiirc.com)) [21:20:59] *** Joins: param (~param@157.49.111.185) [21:38:45] *** Joins: pzedlews_ (uid285827@gateway/web/irccloud.com/x-sxkauveirrvioyjj) [21:52:41] *** Quits: param (~param@157.49.111.185) (Quit: Going offline, see ya! (www.adiirc.com)) [21:53:18] *** Joins: param (~param@157.49.111.185) [22:02:27] *** Quits: param (~param@157.49.111.185) (Ping timeout: 240 seconds)