[00:49:35] *** Joins: ziyeyang_ (~ziyeyang@192.55.54.38)
[01:10:32] *** Joins: tomzawadzki (~tomzawadz@134.134.139.72)
[01:10:35] *** Quits: tomzawadzki (~tomzawadz@134.134.139.72) (Remote host closed the connection)
[01:10:47] *** Joins: tomzawadzki (~tomzawadz@134.134.139.72)
[02:03:45] *** Joins: tkulasek (~tkulasek@192.55.54.42)
[02:31:39] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds)
[04:00:13] *** Joins: sbasierx (sbasierx@nat/intel/x-ufwffkxfgtpqxlqc)
[05:01:37] *** Quits: ziyeyang_ (~ziyeyang@192.55.54.38) (Ping timeout: 248 seconds)
[05:36:53] *** Quits: tkulasek (~tkulasek@192.55.54.42) (Ping timeout: 240 seconds)
[05:43:56] *** Joins: tkulasek (~tkulasek@134.134.139.74)
[05:50:29] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-hfdnosvscmeyngwk)
[06:20:09] *** Quits: sbasierx (sbasierx@nat/intel/x-ufwffkxfgtpqxlqc) (Remote host closed the connection)
[06:44:06] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-hfdnosvscmeyngwk) (Remote host closed the connection)
[07:04:03] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-hzapxtwvtbxvwkbv)
[07:10:34] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-hzapxtwvtbxvwkbv) (Remote host closed the connection)
[07:37:22] *** Quits: tkulasek (~tkulasek@134.134.139.74) (Ping timeout: 260 seconds)
[07:42:43] *** Joins: tkulasek (~tkulasek@134.134.139.74)
[08:29:59] *** Quits: tomzawadzki (~tomzawadz@134.134.139.72) (Ping timeout: 260 seconds)
[08:40:00] jim : drv : commented on this card https://trello.com/c/Ii32JeN4/23-add-an-rpc-to-stop-accepting-new-connection-on-a-particular-address-for-a-given-subsystem for the approach.
[09:19:57] drv: can you review this patch and one after it? https://review.gerrithub.io/#/c/402529/
[09:20:21] yep
[09:27:27] param: I posted a response on the card
[09:27:47] pwodkowx: can you confirm that you want to commit this to master? https://review.gerrithub.io/#/c/402531/4
[09:28:09] drv : I just saw the comment.. will proceed further as suggested..
[09:29:02] thanks
[09:35:33] jimharris: ping on https://review.gerrithub.io/#/c/402381/
[09:38:21] jimharris: G'morning Jim. Think you can get to the review of https://review.gerrithub.io/#/c/401243/ today? I'm loathe to be a pest. It's just that it touches quite a few files, including one or more on which I know I'll have a dependency on future — read: very soon — new patches in my continued lib:exit/abort work. Thanks.
[09:46:15] jimharris: one of the lvol tests added back a libuuid call - build fix is here: https://review.gerrithub.io/#/c/403205/
[09:46:23] lhodev: looks good to me, but I'll let Jim take a look too :)
[09:46:31] lhodev: i just added my +2
[09:46:38] Thanks Daniel, and Jim!
[09:46:49] once drv adds his +2 we'll commit it
[09:46:53] I just did too
[09:47:17] pushed
[09:47:46] Sweet! Thx again guys!
[09:53:01] drv : remove_listener function is in the code.. we might just have to add the RPC call
[09:53:18] ok, I didn't remember if we had that yet - that should be pretty straightforward, then
[09:55:39] *** Quits: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) (Quit: Leaving.)
[10:51:35] *** Quits: peluse___ (48d0c853@gateway/web/freenode/ip.72.208.200.83) (Ping timeout: 260 seconds)
[10:51:47] *** Joins: destrudo (~destrudo@tomba.sonic.net)
[10:52:06] Help, help, I'm trapped in training!
[11:26:43] drv : Jim : I have pushed the changes https://review.gerrithub.io/#/c/403211/1/app/nvmf_tgt/nvmf_rpc.c
[11:45:52] *** Quits: tkulasek (~tkulasek@134.134.139.74) (Ping timeout: 260 seconds)
[12:04:43] *** Joins: jstern (jstern@nat/intel/x-nzcemsixktrgtrxv)
[12:07:14] *** Joins: peluse (peluse@nat/intel/x-zzekrqvnzfwxlbcz)
[12:07:44] *** Joins: pawelkax (pawelkax@nat/intel/x-vdfsexmituffkyes)
[12:13:57] *** Joins: lhodev (~Adium@inet-hqmc06-o.oracle.com)
[14:23:04] jimharris: I pushed a first attempt at a unified target app - obviously needs docs, tests, etc., but it seems to work: https://review.gerrithub.io/#/c/403219/
[14:42:21] *** Joins: tkulasek (~tkulasek@192.55.54.44)
[14:46:49] *** Quits: tkulasek (~tkulasek@192.55.54.44) (Ping timeout: 260 seconds)
[15:00:11] awesome
[15:00:27] we must have done something right - because that app is simple
[15:01:47] yeah, lots of blood, sweat, and tears to get there, but now it's very clean :)
[15:02:16] this doesn't solve any of the issues with conf-only global params, but that should be doable as a separate step
[15:03:35] yeah but we have the problem today with standalone targets
[15:04:42] yep
[15:04:52] and you should be able to build a single config file with all of the relevant sections for now
[15:06:23] hi param - thanks! looks like it failed the test pool though (check_format.sh)
[15:06:49] fyi - you can run check_format.sh locally on your system before you push the patch to the test pool to avoid an extra run through the test pool
[15:18:28] *** Quits: lhodev (~Adium@inet-hqmc06-o.oracle.com) (Remote host closed the connection)
[15:19:32] jimharris: if you get a chance, can you rebase your "blob: queue sync requests" patch? https://review.gerrithub.io/#/c/401257/
[15:45:01] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net)
[15:45:31] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97)
[15:49:13] *** Quits: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) (Ping timeout: 240 seconds)
[15:50:15] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net)
[15:51:04] done
[15:54:27] *** Quits: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) (Ping timeout: 240 seconds)
[15:58:45] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net)
[16:25:18] *** Joins: relling (ac3a1315@gateway/web/freenode/ip.172.58.19.21)
[16:43:51] *** Quits: relling (ac3a1315@gateway/web/freenode/ip.172.58.19.21) (Quit: Page closed)
[17:25:01] klateck: check out drv's patch series here: https://review.gerrithub.io/#/c/403218/
[17:25:14] this enables a consolidated spdk_tgt - one target which does iSCSI, NVMe-oF and vhost
[17:25:47] I haven't tested the vhost part at all yet, aside from making sure it compiles and runs
[17:25:57] could you have someone start looking at migrating some of our existing tests to use the consolidated target?
[17:26:03] oh yeah - and what drv said
[17:26:33] yeah, not sure what our long-term strategy should be, but at the very least, switching the existing tests to use it would be nice
[17:26:54] and then we'll need some tests that actually start iscsi + nvmf + vhost in various combinations
[17:27:42] i guess i'm thinking long-term the individual targets go away? and maybe there are configure options to disable specified frontends?
[17:27:49] yeah, sounds good to me
[17:27:54] vhost already has a configure switch
[17:28:02] and we can add them for the others if that is something people are interested in
[17:28:34] i guess it could be done at runtime too once we have the initialization/configuration stuff in that pwodkowx and Shuhei are working on
[17:28:56] i.e. don't start this subsystem
[17:29:17] yep
[17:29:44] and I would guess they probably don't add a whole lot of overhead anyway
[17:29:57] we can tweak nvmf and iscsi to avoid starting the acceptor poller until there's something to listen for
[17:32:29] *** Quits: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) (Ping timeout: 260 seconds)
[17:41:17] Hi Jim, Daniel, looks nice patch! I wanted any idea to pass config info to NVMf-tgt through JSON-RPC because NVMf-tgt starts after completing other subsystems initialization.
[17:43:20] Also spdk_tgt sounds good to me.
[17:51:56] hi Shuhei - I think part of drv's patches was to modify nvmf target to make it a subsystem
[17:52:44] maybe some more changes are still needed, but hopefully that will help ability to configure nvmf-tgt with JSON-RPC similar to the changes you are making for the iSCSI target
[17:55:10] Hi Jim, yes, I found that in his patch. NVMf-tgt just load options first and then go, hence I hope if we change just a part of startup we will be able to start NVMf-tgt by JSON-RPC.
[17:56:06] But I will do JSON config by iSCSI first.
[18:03:43] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-nxtyqsierquduwnz)
[18:19:39] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-nxtyqsierquduwnz) (Ping timeout: 256 seconds)
[18:41:39] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net)
[19:03:27] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-ktzekbsfzdvsswue)
[19:16:24] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-ktzekbsfzdvsswue) (Quit: Leaving)
[19:16:50] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.74)
[19:50:54] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.74) (Quit: Leaving)
[20:02:28] Jim : I did run check_format.sh and i committed the changes.,
[20:02:57] I use Ubuntu development box and the test has passed in Ubuntu
[20:22:40] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds)
[21:13:06] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-dsnqrtrcxuhrcdim)
[21:16:39] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-dsnqrtrcxuhrcdim) (Client Quit)
[21:21:03] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-odieecyijdaezpql)
[21:21:32] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-odieecyijdaezpql) (Client Quit)
[21:40:32] Jim : the error is space before tab.. I guess ./scripts/check_format.sh does not auto format this error..
[21:40:59] I assumed that no manual change is required once i run this script