[00:30:11] *** Joins: JamesLiu123 (~James@2601:640:8300:10f3:df5:ac26:7768:66e5) [00:48:43] *** Joins: tomzawadzki (~tomzawadz@192.55.54.42) [00:50:24] *** Joins: tzawadzki (~tomzawadz@134.134.139.72) [00:50:24] *** Quits: tomzawadzki (~tomzawadz@192.55.54.42) (Remote host closed the connection) [01:12:04] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [01:24:50] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [01:58:17] *** Quits: JamesLiu123 (~James@2601:640:8300:10f3:df5:ac26:7768:66e5) (Remote host closed the connection) [02:19:06] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [02:26:33] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [03:58:52] *** Joins: JamesLiu123 (~James@2601:640:8300:10f3:df5:ac26:7768:66e5) [04:02:51] *** Quits: JamesLiu123 (~James@2601:640:8300:10f3:df5:ac26:7768:66e5) (Ping timeout: 240 seconds) [06:45:56] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [08:01:57] *** Quits: tzawadzki (~tomzawadz@134.134.139.72) (Remote host closed the connection) [08:21:12] *** Joins: Brisk-Branded (~Garret@165.227.217.42) [08:29:53] sheng__: vhost don't support multiple connections to the same target (a.k.a controller). but you should be abble to construct another target with the same set of bdevs. This currently not tested but should work. [08:44:47] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [09:41:41] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [10:59:39] *** Joins: JamesLiu123 (~James@2601:640:8300:10f3:df5:ac26:7768:66e5) [11:04:00] *** Quits: JamesLiu123 (~James@2601:640:8300:10f3:df5:ac26:7768:66e5) (Ping timeout: 246 seconds) [11:55:59] *** Joins: JamesLiu123 (~James@2601:640:8300:10f3:8cfe:37e3:b69a:e2f6) [12:00:11] *** Quits: JamesLiu123 (~James@2601:640:8300:10f3:8cfe:37e3:b69a:e2f6) (Ping timeout: 240 seconds) [12:14:26] *** Quits: nKumar (uid239884@gateway/web/irccloud.com/x-szmizwohfgjvstgr) (Ping timeout: 276 seconds) [12:27:51] sheng__: do your multiple processes need to access the same blocks on that device, or do you want to carve that device up into logical volumes and present a different one to each process? [12:30:50] drv: pls check my comment for https://review.gerrithub.io/#/c/386115/13/include/spdk/jsonrpc_util.h@76 [12:32:22] pwodkowx: I don't see a comment - did you post them? [12:33:14] drv: yeah, forget to hit the replay button, fixed :D [12:37:25] I definitely agree that we should be able to simplify the implementation of RPC methods a lot [12:37:38] but I just want to make sure we can handle the more complex cases, like nested arrays and objects [12:39:00] in request? [12:39:44] yes [12:40:13] How we now handle nested arrays and objects in request? I can remember such code [12:40:28] can point me some file? [12:41:26] the top-level decoder may pass a function that calls spdk_json_decode_array or object, for example "initiators" in the iSCSI add_initiator_group method [12:41:52] let me see if I can find a more complex one - iSCSI has a lot of the tricker RPC uses [12:43:27] construct_nvmf_subsystem also has some nested arrays and objects [12:43:58] "listen_addresses" parameter is an array of objects [12:44:15] look at it as an example now because I'm about to gut that rpc [12:44:25] and it may not have nested arrays when I'm done [12:44:38] but we should definitely support nested arrays/objects [12:47:14] ok, I don't think this will be an issue in my very-early-poc :) [12:50:02] darsto is really cranking away on this virtio refactor [12:50:04] looking good [12:52:05] I will try to address this. I wan't to keep the behavior that the request object will manage all parameter internally. Maybe not exactly like it is done currently [12:53:41] we could possibly add another function pointer to the decoder to indicate how to free itself; not sure if that is the best way forward, though [13:04:26] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [14:08:18] *** Joins: VGSalii (~VGSalii@185.80.220.110) [14:22:11] *** Joins: nKumar (uid239884@gateway/web/irccloud.com/x-rapzmbkxpihrofww) [14:40:44] *** Joins: VGSalii__ (~VGSalii@95.158.48.160) [14:44:30] *** Quits: VGSalii (~VGSalii@185.80.220.110) (Ping timeout: 246 seconds) [15:13:19] *** Joins: VGSalii_ (~VGSalii@185.80.220.165) [15:17:22] *** Quits: VGSalii__ (~VGSalii@95.158.48.160) (Ping timeout: 272 seconds) [15:58:10] *** Joins: pzedlews_ (~pzedlews@178235246122.katowice.vectranet.pl) [16:03:13] *** Quits: pzedlews_ (~pzedlews@178235246122.katowice.vectranet.pl) (Quit: Leaving) [16:04:10] *** Joins: pzedlews_ (~pzedlews@178235246122.katowice.vectranet.pl) [16:06:03] *** Quits: pzedlews_ (~pzedlews@178235246122.katowice.vectranet.pl) (Client Quit) [16:48:34] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [16:58:51] *** Joins: VGSalii33 (~VGSalii@95.158.48.160) [16:58:57] *** Quits: VGSalii_ (~VGSalii@185.80.220.165) (Ping timeout: 248 seconds) [16:59:15] *** Quits: VGSalii33 (~VGSalii@95.158.48.160) (Remote host closed the connection) [16:59:41] *** Joins: VGSalii33 (~VGSalii@95.158.48.160) [17:20:19] *** Joins: VGSalii_ (~VGSalii@185.80.220.110) [17:23:27] *** Quits: VGSalii33 (~VGSalii@95.158.48.160) (Ping timeout: 240 seconds) [17:59:30] *** Quits: VGSalii_ (~VGSalii@185.80.220.110) (Ping timeout: 272 seconds) [17:59:45] *** Joins: VGSalii_ (~VGSalii@185.156.175.146) [18:52:54] *** Joins: VGSalii__ (~VGSalii@95.158.48.160) [18:56:27] *** Quits: VGSalii_ (~VGSalii@185.156.175.146) (Ping timeout: 240 seconds) [18:56:45] *** Joins: VGSalii (~VGSalii@185.80.220.110) [18:57:17] *** Quits: VGSalii__ (~VGSalii@95.158.48.160) (Ping timeout: 252 seconds) [19:13:51] *** Quits: VGSalii (~VGSalii@185.80.220.110) (Read error: Connection reset by peer) [22:04:23] *** Joins: JamesLiu123 (~James@c-73-70-222-173.hsd1.ca.comcast.net) [22:15:34] @bwalker: we may have both use cases. multiple processes access same whole device and multiple processes access different partitions of the device. [22:19:44] *** Quits: JamesLiu123 (~James@c-73-70-222-173.hsd1.ca.comcast.net) (Remote host closed the connection) [23:22:09] *** Quits: sheng__ (1805dfeb@gateway/web/freenode/ip.24.5.223.235) (Quit: Page closed)