[01:28:24] *** Joins: tomzawadzki (~tomzawadz@134.134.139.74) [02:32:50] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [02:34:11] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [03:00:07] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [03:06:05] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [04:03:57] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [04:55:07] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [05:05:44] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [05:40:45] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [05:52:00] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [06:27:58] *** Quits: guerby (~guerby@april/board/guerby) (Ping timeout: 255 seconds) [06:46:18] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [06:51:35] *** Joins: guerby (~guerby@april/board/guerby) [07:51:54] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [08:02:51] *** Quits: tomzawadzki (~tomzawadz@134.134.139.74) (Remote host closed the connection) [08:03:08] *** Joins: tomzawadzki (tomzawadzk@nat/intel/x-iuacqxrvxhzkoqma) [08:17:07] drv, QQ: you made a comment about an invalid NQN name in a recent patch (https://review.gerrithub.io/#/c/390381/) - assuming this test is doing IO to that target, does the CI pass simply because nobody is validating the name in the IO path? [08:51:39] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [09:02:37] peluse: right, we have a function that checks for NQN validity, but it doesn't fully validate all the requirements - that should also be fixed [09:02:56] spdk_nvmf_valid_nqn() [09:03:09] cool, I'll throw it up on trello [09:03:10] thanks [09:03:45] the reason it was changed is because FIO doesn't allow colons in the filename (it uses that as a file separator), but we need to figure out some other way around that problem [09:04:02] yeah, I saw that in the comments. pisser [09:04:34] maybe an upstream tweak to FIO [09:05:50] yeah, or maybe there is a way to escape the colon that we just haven't discovered yet [09:08:21] heh, 'escape the colon' :) [09:09:10] hello spdk architecture meeting [09:37:50] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [11:12:50] *** Quits: tomzawadzki (tomzawadzk@nat/intel/x-iuacqxrvxhzkoqma) (Ping timeout: 272 seconds) [13:51:20] *** Joins: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) [14:57:40] scan-build really baffles me sometimes [14:57:43] https://review.gerrithub.io/#/c/391507/ [14:58:10] so scan-build found some issues in blob_ut.c - but those issues have been there for while [14:58:36] but for some reason adding another test to blob_ut.c makes scan-build find those issues now [15:02:17] jimharris, you know I've seen that too and keep forgetting to mention it. It almost seems like there's some mystery exception file somewhere that allows some of these things to be ignored but new ones not to be.... [15:02:59] it's probably because they are using global variables (g_blob) [15:04:43] we should probably also just use the fatal version of CU_ASSERT everywhere [15:04:53] not much of a reason to keep running after a test has failed [15:05:30] not sure about that one - doesn't that mean it just immediately aborts on any missed assertion? [15:05:39] yes [15:05:45] -1 from me [15:07:20] add this to check_format.sh [15:07:30] git grep "!= NULL" test/unit | grep -w CU_ASSERT [15:07:57] 83 lines [15:07:59] :( [15:17:40] *** Quits: ChanServ (ChanServ@services.) (*.net *.split) [15:24:22] *** Joins: ChanServ (ChanServ@services.) [15:24:22] *** wolfe.freenode.net sets mode: +o ChanServ [15:28:57] *** Quits: ChanServ (ChanServ@services.) (*.net *.split) [15:31:45] *** Joins: ChanServ (ChanServ@services.) [15:31:45] *** wolfe.freenode.net sets mode: +o ChanServ [16:13:51] FYI updated blobstore programmer's guide proposal (and template) are up: https://review.gerrithub.io/384118 [16:38:22] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-vsdmjaylximvtstf) [17:23:48] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [17:59:09] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-vsdmjaylximvtstf) (Ping timeout: 264 seconds) [18:07:24] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [18:09:21] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-upyvkpdceceiqfav) [18:20:32] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-upyvkpdceceiqfav) (Remote host closed the connection) [18:21:00] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.82) [19:09:18] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.82) (Ping timeout: 265 seconds) [19:32:33] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.82) [19:56:42] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.82) (Remote host closed the connection) [19:57:35] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.82) [20:37:16] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.82) (Remote host closed the connection) [20:37:22] *** Joins: ziyeyang__ (~ziyeyang@192.55.54.39) [20:46:53] *** Quits: ziyeyang__ (~ziyeyang@192.55.54.39) (Ping timeout: 256 seconds) [22:07:03] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.82) [23:08:35] *** Quits: sage__ (~quassel@64.111.99.127) (Ping timeout: 240 seconds) [23:10:32] *** Joins: sage__ (~quassel@2607:f298:5:101d:f816:3eff:fe21:1966)