[01:19:39] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [06:28:01] *** Joins: tomzawadzki (~tomzawadz@134.134.139.82) [06:52:04] feel free to post any suggestions regarding vhost user guide https://review.gerrithub.io/c/391603 [08:41:21] *** Quits: tomzawadzki (~tomzawadz@134.134.139.82) (Ping timeout: 248 seconds) [08:45:35] *** Quits: boutcher (~boutcher@66.113.132.66) (Ping timeout: 255 seconds) [08:48:35] *** Joins: boutcher (~boutcher@66.113.132.66) [09:07:14] *** Quits: boutcher (~boutcher@66.113.132.66) (Read error: Connection reset by peer) [13:11:19] just curious if anyone uses chrome on macos and has a problem where the commit message window in GH is really narrow so you have to use the scroll bars to read more than like 40 or 50 chars... annoying as hell [13:19:21] peluse: do you have an example review? It should be wide enough to show the normal width that git wraps commit messages at [13:19:46] which is 72 for the main body of the commit message [13:20:55] its probably something in my chrome theme or something, maybe I'll try resetting it. I emailed you a screenshot of the mess I have to look at :) [13:21:21] hm, yeah, that looks busted [13:21:26] maybe it doesn't scale right with zoom [13:21:37] or high-DPI screen [13:22:51] you can try the "New UI" button down at the bottom [13:23:05] it doesn't have quite all of the features of the default UI yet, but it seems to work OK [13:24:02] may give that a shot but yeah it was a font selection in chrome that was too large, looks way more normal now. thanks [13:24:38] yeah, normal font size and cmd+ to zoom works like a champ! [13:24:44] cool [15:47:15] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [16:21:47] Hi, current iSCSI target use perror() in more than 10 cases (and bdev_aio use perror() in 2 cases). Is it OK or better to change perror() to SPDK_ERRLOG with errno? [16:22:28] lib/conf and lib/event also use perror(). [16:26:18] Anyway I'll do and propose this to GerritHub. Thanks. [16:27:39] Shuhei, I asked something similar a while back and essentially the SPDK macros should be used in all library components don't really make sense for applications. I was asking about a sample app though so one of the guys would have to comment on the iSCSI target... [16:30:00] Thank you Paul! [16:31:19] yeah, not a lot of help as I could see it go either way for the iSCSI target code [16:35:14] definitely any perror() in lib/ should be replaced with SPDK_ERRLOG or similar functions [16:35:30] I think there was a Trello card for that, but maybe it got closed [16:35:56] perror in things in app/ or examples/ isn't necessarily bad, but definitely remove them all from anything in lib/ [16:37:48] Thank you Daniel, Ben, I found in the trello board. https://trello.com/c/lZzBjrw3/18-remove-use-of-printf-fprintf-and-perror-for-logging-in-library-code [16:38:18] I'll include this activity into my task, thank you. [16:38:22] cool, sounds good [16:38:49] most of the ones left in lib/iscsi seem to be for malloc() failure, so they can probably be replaced with hard-coded "out of memory" strings [16:38:53] with SPDK_ERRLOG [16:40:28] Thank you for your advice, very helpful!. [16:40:55] (if it was perror() for something more complex, we might want a more detailed error message depending on the errno value, but it looks like that doesn't apply here) [18:17:10] *** Joins: guerby_ (~guerby@ip165.tetaneutral.net) [18:17:24] *** Quits: guerby (~guerby@april/board/guerby) (Read error: Connection reset by peer) [18:42:03] *** Joins: guerby (~guerby@ip165.tetaneutral.net) [18:42:03] *** Quits: guerby (~guerby@ip165.tetaneutral.net) (Changing host) [18:42:03] *** Joins: guerby (~guerby@april/board/guerby) [18:42:10] *** Quits: guerby_ (~guerby@ip165.tetaneutral.net) (Read error: Connection reset by peer) [19:32:40] *** Quits: ChanServ (ChanServ@services.) (*.net *.split) [19:34:37] *** Joins: ChanServ (ChanServ@services.) [19:34:38] *** wolfe.freenode.net sets mode: +o ChanServ [21:41:39] *** Quits: drv (daniel@oak.drv.nu) (Quit: leaving) [21:41:57] *** Joins: drv (quassel@oak.drv.nu) [21:42:02] *** ChanServ sets mode: +o drv [22:02:55] *** Quits: drv (quassel@oak.drv.nu) (Quit: drv) [22:03:08] *** Joins: drv (daniel@oak.drv.nu) [22:03:08] *** ChanServ sets mode: +o drv