[00:23:41] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) [04:33:10] *** Quits: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) (Quit: Textual IRC Client: www.textualapp.com) [04:45:36] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) [05:01:42] *** Quits: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [05:10:16] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) [07:11:45] *** Quits: tomzawadzki (~tzawadzk@134.134.139.77) (Ping timeout: 240 seconds) [09:48:52] 17.07 was tagged yesterday, we just merged the tag for 17.10-pre [09:49:02] so now we're going to trickle out merging all of the backlog of patches [09:53:30] nice! [09:54:10] so for everyone out there looking to cut their teeth on something relatively straightforward, check out the low hanging fruit column on Trello at https://trello.com/b/P5xBO7UR/things-to-do [09:55:02] if everyone available can do code reviews, as much as they are comfortable with that, it would help us move through this backlog of available patches in the next few days [09:55:10] bwalker, drv - if you guys could check out hello_blob soon that'd be great, I'm using code snippets for the SNIA talk so would like to get them finalized soon [09:55:20] bwalker, yeah, will do. I'll hit a few this afternoon for sure! [09:57:32] bwalker, and for everyone's benefit, this is still the best place to look for review work correct? https://review.gerrithub.io/#/dashboard/?Outgoing=projects:spdk+o:self+status:open&Needs%2520Review=projects:spdk+r:self+-o:self+status:open&Open=projects:spdk+status:open+-r:self+-o:self (link U should have if you follow the Developer directions on http://www.spdk.io/development/) [09:57:49] man, that didn't paste very pretty :( [09:58:03] not pretty, but the link did work [09:58:05] and yes, that's right [10:03:39] We actually figured out a few tricks to improve the query recently [10:03:42] here is a better one: [10:03:43] https://review.gerrithub.io/#/dashboard/?Outgoing=projects:spdk+o:self+status:open&Needs%20Review=projects:spdk+-o:self+status:open+label:Verified%253E%253D1&Open=projects:spdk+status:open+-o:self+-label:Verified%253E%253D1 [10:03:49] I'll update the documentation page to add this [10:04:04] the other one is fine too - this one just shows only reviews that passed the tests in the "Needs Review" section [12:24:35] cool [12:27:39] I paste that in my browser and it words fine but as a new menu item (starting with #) it doesn't like something in there [12:45:16] I think the URL encoding of some of the characters (e.g. %253E) is the problem, but I spent a bunch of time trying to make it work and failed [12:57:08] drv, yeah, thanks I didn't try anything as I figured bwalker would just fix it for me :) [13:00:02] here's my fix: make a bookmark from the link [13:00:12] and click that instead of the link in the gerrit header [13:00:12] I wish there was just some kind of "save current view" button [13:00:22] but yeah, I have just made it into a bookmark on the toolbar [13:04:31] LOL, yeah that's what I did too :) [13:04:49] holy moly the review backlog is gigantic! [13:04:58] we're making forward progress now :) [13:05:00] relatively speaking of course... [13:57:52] bwalker, thanks for breaking up those app.c changes, made a world of difference in seeing what & why! [13:58:48] yeah, I got lost in the combined patch too [13:59:01] phew :) [13:59:59] drv made me do it [14:00:59] oh so you're saying my comments were ignored huh? I see how you are... haha [14:01:43] * peluse is planning on his next commit message saying "was broke, now fixed" :) [14:06:01] I hadn't read yours yet [14:06:47] *** Quits: sethhowe_ (~sethhowe@134.134.139.76) (Remote host closed the connection) [14:09:33] *** Joins: sethhowe (~sethhowe@192.55.54.42) [14:10:23] I was channeling drv apparently.. you already addressed it by breaking up the patch [14:16:57] hey, I'm gonna do a 2nd blobstore app (nights/weekends) like I was thinking for hello_world initially (but I like the simple thing it turned out to be). Planning on doing a CLI, I put a card up on trello to list things it should do, feel free to chime in and I'll check again if I haven't heard anything before I do too much [14:19:00] what sort of things would the CLI do? [14:20:05] card is on trello now https://trello.com/b/P5xBO7UR/things-to-do [14:23:13] which lists the things I think it should do and other can add stuff or comment, whatever... [14:32:51] *** Quits: sethhowe (~sethhowe@192.55.54.42) (Remote host closed the connection) [14:34:31] peluse: I think that link just goes to the things to do board [14:34:35] guessing you meant this card: https://trello.com/c/0E3ADk7R [14:34:46] oh yeah, thanks [14:35:02] (got that from the "Share and more" link on the card) [14:35:10] I was about to ask! [14:35:33] I think a CLI/menu-driven/something tool would be great [14:35:54] *** Joins: sethhowe (~sethhowe@192.55.54.42) [14:36:24] probably a useful thing to have for debugging as well, beyond just an example app [14:39:50] drv, yeah that's what I was thinking as well [14:40:49] we definitely need a CLI tool [14:41:23] we have the beginnings of one already though at test/lib/blobfs/mkfs [14:41:28] all it can do is format a disk as a blobstore [14:41:35] but it's a start [14:43:34] I think Vishal was working on something like this at one point too - might be worth syncing up if he's got any work in progress [14:43:49] it's likely in our old gerrit [14:44:19] peluse: we merged the first patch in your UT series - I think the other ones need to be rebased [15:19:26] PSA: quickly switching over build pool to use pre-allocated host huge pages, there will be a short pause. [15:25:09] drv, OK I'll check it out. thanks [15:25:46] bwalker, super high level notes for blobstore API changes here: https://trello.com/c/KH8p4TQp (feel free to add/edit/correct at will, I'll update as I dig in more) [15:28:12] drv, ugh, yeah. Hey, I was still learning/attempting to do all of those on one branch and didn't quite get it right so there's kind of a mix in there of dependencies. GH shows "related patches" but do you know if you can tell which ones it depends on vs which ones depend on it? [15:38:34] wrt anything Vishal started, yeah I'll talk to him but need to start mostly from scratch to actually get some learning out of it anyway... [15:40:52] *** Quits: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [15:42:15] drv, never mind I'll just go through them all even if I have to do it a few times as each lands [15:58:07] OK, the nvme UT patches are all rebased and back in the test queue... [23:09:02] *** Joins: tomzawadzki (~tzawadzk@134.134.139.73) [23:20:45] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl)