[01:23:50] *** Quits: ziyeyang_ (~ziyeyang@192.55.54.40) (Remote host closed the connection) [02:26:48] *** Quits: cunyinch_ (cunyinch@nat/intel/x-gpqbgenytrkhcrwb) (Remote host closed the connection) [03:29:14] *** Quits: Roman_ (c0c6972b@gateway/web/freenode/ip.192.198.151.43) (Ping timeout: 260 seconds) [07:40:03] *** ChanServ sets mode: +o jimharris [07:42:56] i think we will be calling it after we get reset injection into cunyinch's bdev injection module [09:29:48] jimharris: I think that function you proposed to add to spdk_allocate_thread can become our general mechanism for abstracting out a message pass [09:30:03] which allows us to remove the event library dependency from nearly all of our libraries [10:11:04] *** Joins: jstern_ (jstern@nat/intel/x-pzsemweocqefvixg) [11:18:07] jimharris: can you take a look at the scsi_bdev unit test patch? (the first one in the series) [11:29:36] *** Joins: vishal_ (c0373627@gateway/web/freenode/ip.192.55.54.39) [11:33:59] *** Quits: vishal_ (c0373627@gateway/web/freenode/ip.192.55.54.39) (Ping timeout: 260 seconds) [11:38:14] *** Joins: vermavis (c0373627@gateway/web/freenode/ip.192.55.54.39) [12:13:04] *** Quits: vermavis (c0373627@gateway/web/freenode/ip.192.55.54.39) (Ping timeout: 260 seconds) [13:05:38] *** Joins: peluse_ (~peluse@2600:8800:140a:ae18:ecbc:32da:506e:6aa5) [13:15:15] *** Joins: whitepa (~textual@2601:601:1200:f23b:70ca:aeff:65d0:3191) [13:28:11] *** Quits: whitepa (~textual@2601:601:1200:f23b:70ca:aeff:65d0:3191) (Quit: Textual IRC Client: www.textualapp.com) [13:28:23] *** Joins: whitepa (~whitepa@2601:601:1200:f23b:70ca:aeff:65d0:3191) [13:36:11] drv: done [13:36:15] thanks [14:17:14] anyone know why I'm getting 'not Signed-off-by author/committer/uploader in commit message footer' even though the signed off note is in my commit msg? [14:17:25] well, or have a suggestion... [14:17:37] you have to do 'git commit -s' [14:17:41] to "sign off" a commit [14:17:47] I did [14:18:06] that's how it got in there in the first place :) [14:18:23] hmm [14:18:44] does the author match the sign off? [14:18:47] i.e. same name/email? [14:19:19] only difference between this one and the last 2 I did is that this one is the 2nd commit on a branch where I already had one, I didn't change anything since (except some code and the commit msgg of course) [14:19:19] is the signed off by user a known user by Gerrit? [14:19:33] yup [14:20:11] leave it to me to find simple shit that can be broken! [14:20:29] well, probably user error of course [14:21:03] just noticed this though: .git/hooks/commit-msg: line 1: #!/bin/sh: No such file or directory [14:21:26] I'm ssh'ing into a machine there in the lab somewhere because of some stupid VPN issues on my local machine with my dev VM [14:21:45] hmm, that sounds bad :) [14:22:01] do you have DOS newlines or something? [14:22:20] only editing in vi on the machine you told me to ssh into [14:22:30] oh wait, I did paste a few functions in from an editor that might have [14:25:36] you can try dos2unix on everything, shouldn't hurt if they are already in the right format [14:29:25] yesh, will do [14:30:30] jimharris: I updated some of the SCSI reviews to clean up the API but keep the fields around [14:41:33] well, that wasn't it [14:43:09] I can take a look if you are in the office (or if you can paste the commit message somewhere) [14:46:02] yeah, one sec. the bash err message was CRLF in my commit-msg script because I pasted that one in, scp'd it over and that went away but it still doesn't like my commit message for some reason [14:53:42] WTF, I did a rebase -i and picked both this change and the prev (1st commit on this branch) and it took it [14:54:58] gerrit does seem show to the related commits correctly [14:55:18] guess I'll try third... see [14:55:28] what explodes next :) [15:09:42] looks like scan-build is next on the list of things to explode :) [15:09:57] you can see the clang static analyzer output in the scan-build directory of each agent [15:14:08] drv: should I remove the explicit git submodule operations in autobuild.sh as well? [15:14:30] yes [15:14:54] the pool should update all the submodules automatically, so they will already be in place when autobuild.sh runs [15:16:09] drv, was the scan-build comment for me? [15:16:34] yes [15:16:41] yay :) [15:16:45] that is why your part 2 build is failing [15:17:05] check the scan-build output on wkb-fedora-03 [15:17:30] the first one is just a dead store, which can be removed, and the second one can probably be silenced by assigning NULL into that global at the end of the test function [15:17:31] checking, probably the --wrap LDFLAG [15:18:09] also there's two "part 3"s :) [15:18:33] counting is over rated [15:20:29] didn't even know we had to check the scan-build dir for static anal [15:21:01] I've been doing these series on the same branch so this will give me a great oppty to try and fix something small on an older commit [15:21:27] yeah, get your personal stgit trainer on the job ;) [15:22:26] heh, ben already gave me a cheat sheet which I'm sure I'll royally screw up the first few times... wheee [15:26:51] does the clang static analyzer run locally for us before we push? [15:27:08] (or is there a scripts for it somewhere I should say) [15:32:00] I just do "scan-build make" [15:32:00] you can run it locally [15:32:04] and it works [15:32:14] to reproduce what the build pool is doing, you should do scan-build make CONFIG_DEBUG=y [15:32:31] I think the package is called "clang-analyzer" if you need to install it [15:34:11] *** Quits: jstern_ (jstern@nat/intel/x-pzsemweocqefvixg) (Ping timeout: 255 seconds) [15:40:14] jimharris: it looks like the submodule build failed; did the -fPIC get lost somewhere along the way? [15:40:27] i'm looking at it now [15:43:43] ok, cool. How about this one, the static analyzer is bitching about a var I set saying I'm not using it but its used in an assertion. is there some sort of something to tell it to ignore that warning? [15:44:14] oh wait, duh. it was right I was wrong :) [15:44:18] crap - I pushed the wrong rev of this patch [17:03:22] *** Joins: tsuyoshi (b42b2067@gateway/web/freenode/ip.180.43.32.103) [17:30:56] *** Joins: changpeng (~changpeng@134.134.139.83) [17:41:53] *** Joins: cunyinch_ (~cunyinch@134.134.139.77) [18:32:05] *** Quits: changpeng (~changpeng@134.134.139.83) (Ping timeout: 268 seconds) [19:21:22] *** Joins: jstern_ (~jstern@192.55.55.41) [19:40:07] *** Joins: changpeng (~changpeng@134.134.139.83) [19:50:46] *** Quits: jstern_ (~jstern@192.55.55.41) (Ping timeout: 255 seconds) [20:44:40] *** Quits: changpeng (~changpeng@134.134.139.83) (Ping timeout: 268 seconds) [20:47:33] *** Joins: changpeng (~changpeng@192.55.54.42) [20:53:18] *** Quits: changpeng (~changpeng@192.55.54.42) (Remote host closed the connection) [21:01:41] *** Joins: jstern_ (jstern@nat/intel/x-lucnrysvfiyeldhm) [21:09:20] *** Quits: jstern_ (jstern@nat/intel/x-lucnrysvfiyeldhm) (Ping timeout: 268 seconds)